Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wrangler should work with proxies #988

Closed
threepointone opened this issue May 13, 2022 · 2 comments · Fixed by #1051
Closed

feat: wrangler should work with proxies #988

threepointone opened this issue May 13, 2022 · 2 comments · Fixed by #1051
Assignees
@rozenmd
Labels
blocked Blocked on other work enhancement New feature or request

Comments

@threepointone
Copy link
Contributor

threepointone commented May 13, 2022 •
edited
Loading

We should read env vars for http_proxy/https_proxy and use them in an agent when we make calls, so as to work with proxies.
@threepointone threepointone added the enhancement New feature or request label May 13, 2022
@threepointone threepointone added this to the 2.1 milestone May 13, 2022
@threepointone
Copy link
Contributor Author

https://github.com/nodejs/undici/blob/main/examples/proxy-agent.js

@petebacondarwin petebacondarwin modified the milestones: Selected for development, Backlog May 15, 2022
@petebacondarwin petebacondarwin moved this to Backlog in workers-sdk May 15, 2022
@petebacondarwin petebacondarwin removed this from the Backlog milestone May 15, 2022
@petebacondarwin petebacondarwin moved this from Backlog to Selected for development in workers-sdk May 16, 2022
@petebacondarwin petebacondarwin moved this from Selected for development to In Progress in workers-sdk May 21, 2022
@petebacondarwin petebacondarwin added the blocked Blocked on other work label May 23, 2022
@petebacondarwin petebacondarwin moved this from In Progress to Selected for development in workers-sdk May 23, 2022
@petebacondarwin
Copy link
Contributor

This is blocked on a release of Undici that contains this fix: nodejs/undici#1451 (comment)

@rozenmd rozenmd self-assigned this May 24, 2022
@rozenmd rozenmd mentioned this issue May 24, 2022
Merged
@rozenmd rozenmd closed this as completed May 24, 2022
Repository owner moved this from Selected for development to Done in workers-sdk May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozenmd rozenmd

Labels
blocked Blocked on other work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement proxy support cloudflare/workers-sdk
3 participants
@petebacondarwin @threepointone @rozenmd