Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should deprecate being able to pass every config value as CF_ env vars (which is possible in wrangler 1!!) #657

Closed
Tracked by #619
caass opened this issue Mar 21, 2022 · 5 comments
Assignees

Comments

@caass
Copy link
Contributor

caass commented Mar 21, 2022

No description provided.

@threepointone
Copy link
Contributor

This one might just be a case of ignoring it till (and if!) people complain and we point them to config docs.

@caass caass self-assigned this Mar 21, 2022
@caass
Copy link
Contributor Author

caass commented Mar 21, 2022

Yeah i mean the fix is already in place, the issue is really one of documentation, right? it wouldn't be too hard to write a checker for CF_ and CLOUDFLARE_ environment vars and just warn...and then if they acknowledge it...i guess put a flag in the config to not print that warning anymore? But def a lower priority until we get complaints

@threepointone
Copy link
Contributor

no flag, and they shouldn't be able to silence the warning either.
thing is, this is also undocumented behaviour. maybe we shouldn't even acknowledge its existence.

@threepointone
Copy link
Contributor

yeah, maaaybe we shouldn't even do this.

@caass
Copy link
Contributor Author

caass commented Mar 21, 2022

mm ok. Feel free to close the issue if you've made up your mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants