Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expire unused assets with [site] #459

Closed
threepointone opened this issue Feb 14, 2022 · 4 comments · Fixed by #587
Closed

feat: expire unused assets with [site] #459

threepointone opened this issue Feb 14, 2022 · 4 comments · Fixed by #587
Assignees
@threepointone
Labels
enhancement New feature or request

Comments

@threepointone
Copy link
Contributor

With Sites/[site] definitions, we currently don't do anything with unused assets. This can lead to bloated kv stores, and slower upload times (because we iterate through all keys in the sites kv store when uploading). The fix is to detect unused assets during upload, and add expiration tags on them.

Related, we should probably do this for wrangler 1 as well.

Related - cloudflare/wrangler-legacy#2096
@threepointone threepointone moved this to Must-have in workers-sdk Feb 14, 2022
@threepointone threepointone added the enhancement New feature or request label Feb 14, 2022
@Electroid Electroid added this to the 2.0 milestone Feb 18, 2022
@threepointone
Copy link
Contributor Author

filed cloudflare/wrangler-legacy#2214 to revert the change in wrangler1.

@threepointone threepointone moved this from Must-have to In Review in workers-sdk Mar 8, 2022
@threepointone threepointone moved this from In Review to In Progress in workers-sdk Mar 8, 2022
@threepointone threepointone self-assigned this Mar 8, 2022
@threepointone threepointone moved this from In Progress to Must-have in workers-sdk Mar 9, 2022
@threepointone threepointone moved this from Must-have to In Review in workers-sdk Mar 14, 2022
@caass caass mentioned this issue Mar 16, 2022
Merged
@caass caass removed their assignment Mar 16, 2022
@threepointone threepointone moved this from In Review to Must-have in workers-sdk Mar 16, 2022
@threepointone threepointone moved this from Must-have to In Review in workers-sdk Mar 17, 2022
Repository owner moved this from In Review to Done in workers-sdk Mar 17, 2022
@threepointone threepointone reopened this Mar 20, 2022
Repository owner moved this from Done to In Progress in workers-sdk Mar 20, 2022
@threepointone
Copy link
Contributor Author

This needs to be redone, there's some subtlety with the implementation that's breaking people's deploys cloudflare/wrangler-legacy#2224

@petebacondarwin
Copy link
Contributor

Urgh! So we can't rely on the current time given in a Docker container to be accurate!!
I think using expiration_ttl will solve this.

Repository owner moved this from In Progress to Done in workers-sdk Mar 21, 2022
@threepointone
Copy link
Contributor Author

Distributed systems 🤪

This was referenced Sep 1, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threepointone threepointone

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expire unused assets in [site] uploads cloudflare/workers-sdk
4 participants
@petebacondarwin @threepointone @Electroid @caass