-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement json bindings for wrangler dev --local
#449
Comments
Dependency: cloudflare/miniflare#218 |
Considering the conversation (in miniflare#218), implementation of Miniflare API, I would like to consider reducing all the flag to Cc: @petebacondarwin |
@mrbbot suggested an alternative approach, which is to use Miniflare programmatically, where we have full access to set the bindings with the correct types. |
Correct. I was thinking about removing the extraneous flags and having the Miniflare programmatically (API) handle the TOML file |
I believe this is now supported as of #633 |
Should we just not have any messaging around the breaking change? Specifically, in wrangler1, |
I think the breaking change should have been with this change: 64d62be |
We implemented json bindings in #438, but we'll need it for
--local
mode as well. The complication here is that this is actually a proper breaking change, and might require changes in miniflare too, as well as some form of warning/messaging.The text was updated successfully, but these errors were encountered: