Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature Request: Consider using prerelease tags based on the soon-to-be-verson #3898

Open
GregBrimble opened this issue Sep 6, 2023 · 1 comment · May be fixed by Laurry-gee/workers-ns#139
Labels
enhancement New feature or request

Comments

@GregBrimble
Copy link
Member

Describe the solution

Right now, we cut prereleases as 0.0.0-${gitHash}. When making API requests, we send the User Agent as wrangler/${version}. This means the API is basically unable to see what rough version this particular Wrangler client is.

Instead, npm supports prerelease tags based off of the upcoming verison (e.g. 4.0.0-alpha.0 is a release candidate for 4.0.0). We could change how we generate our prerelease version tags and adopt something similar to this so we can better gate the behavior of our APIs in the future.

@GregBrimble GregBrimble added the enhancement New feature or request label Sep 6, 2023
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 6, 2023
@RamIdeas
Copy link
Contributor

I have thought this too. +1 to including the base version. Would work and be 'easier' to use the "runId" in the format: 3.24.0-beta.${runId} or 4.0.0-alpha.${runId}.

Can we also store our prereleases on npm rather than github? With tags for the HEAD of a PR: wrangler@pr-1234 -> 3.24.0-beta.${runId}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants