throw error if config is specified in pages (#1278)

Author: Maximo-Guk

.changeset/rotten-radios-wink.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Throw error if user attempts to use config with pages

packages/wrangler/src/__tests__/pages.test.ts

@@ -299,7 +299,6 @@ describe("pages", () => {
           directory  The directory of static files to upload  [string]
 
         Flags:
-          -c, --config   Path to .toml configuration file  [string]
           -h, --help     Show help  [boolean]
           -v, --version  Show version number  [boolean]
 
@@ -969,6 +968,19 @@ describe("pages", () => {
 
       expect(std.err).toMatchInlineSnapshot(`""`);
     });
+
+    it("should throw an error if user attempts to use config with pages", async () => {
+      await expect(
+        runWrangler("pages dev --config foo.toml")
+      ).rejects.toThrowErrorMatchingInlineSnapshot(
+        `"Pages does not support wrangler.toml"`
+      );
+      await expect(
+        runWrangler("pages publish --config foo.toml")
+      ).rejects.toThrowErrorMatchingInlineSnapshot(
+        `"Pages does not support wrangler.toml"`
+      );
+    });
   });
 
   describe("project upload", () => {

packages/wrangler/src/pages/dev.tsx

@@ -92,6 +92,11 @@ export function Options(yargs: Argv): Argv<PagesDevArgs> {
         type: "boolean",
         hidden: true,
       },
+      config: {
+        describe: "Pages does not support wrangler.toml",
+        type: "string",
+        hidden: true,
+      },
       //   // TODO: Miniflare user options
     })
     .epilogue(pagesBetaWarning);
@@ -108,14 +113,18 @@ export const Handler = async ({
   do: durableObjects = [],
   "live-reload": liveReload,
   "node-compat": nodeCompat,
+  config: config,
   _: [_pages, _dev, ...remaining],
 }: ArgumentsCamelCase<PagesDevArgs>) => {
   // Beta message for `wrangler pages <commands>` usage
   logger.log(pagesBetaWarning);
 
   if (!local) {
-    logger.error("Only local mode is supported at the moment.");
-    return;
+    throw new FatalError("Only local mode is supported at the moment.", 1);
+  }
+
+  if (config) {
+    throw new FatalError("Pages does not support wrangler.toml", 1);
   }
 
   const functionsDirectory = "./functions";

packages/wrangler/src/pages/publish.tsx

@@ -59,6 +59,11 @@ export function Options(yargs: Argv): Argv<PublishArgs> {
         description:
           "Whether or not the workspace should be considered dirty for this deployment",
       },
+      config: {
+        describe: "Pages does not support wrangler.toml",
+        type: "string",
+        hidden: true,
+      },
     })
     .epilogue(pagesBetaWarning);
 }
@@ -70,7 +75,12 @@ export const Handler = async ({
   commitHash,
   commitMessage,
   commitDirty,
+  config: wranglerConfig,
 }: ArgumentsCamelCase<PublishArgs>) => {
+  if (wranglerConfig) {
+    throw new FatalError("Pages does not support wrangler.toml", 1);
+  }
+
   if (!directory) {
     throw new FatalError("Must specify a directory.", 1);
   }