Run deploy interactively in C3 (#6569)

Author: penalosa

.changeset/smart-drinks-joke.md

@@ -0,0 +1,5 @@
+---
+"create-cloudflare": patch
+---
+
+Make sure `wrangler deploy` and `wrangler pages deploy` are run in an interactive context in C3, so that users are able to respond to interactive prompts

packages/create-cloudflare/src/__tests__/deploy.test.ts

@@ -130,8 +130,10 @@ describe("deploy helpers", async () => {
 			ctx.template.platform = "pages";
 			ctx.commitMessage = commitMsg;
 			mockInsideGitRepo(false);
-			vi.mocked(runCommand).mockResolvedValueOnce(deployedUrl);
-
+			vi.mocked(runCommand).mockResolvedValueOnce("");
+			vi.mocked(readFile).mockImplementationOnce(
+				() => `{"type":"deploy", "targets":["${deployedUrl}"]}`,
+			);
 			await runDeploy(ctx);
 			expect(runCommand).toHaveBeenCalledWith(
 				["npm", "run", "deploy", "--", "--commit-message", `"${commitMsg}"`],

packages/create-cloudflare/src/deploy.ts

@@ -1,9 +1,13 @@
+import { mkdtemp } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
 import { startSection, updateStatus } from "@cloudflare/cli";
 import { blue, brandColor, dim } from "@cloudflare/cli/colors";
 import TOML from "@iarna/toml";
 import { processArgument } from "helpers/args";
 import { C3_DEFAULTS, openInBrowser } from "helpers/cli";
 import { quoteShellArgs, runCommand } from "helpers/command";
+import { readFile } from "helpers/files";
 import { detectPackageManager } from "helpers/packageManagers";
 import { poll } from "helpers/poll";
 import { isInsideGitRepo } from "./git";
@@ -99,24 +103,42 @@ export const runDeploy = async (ctx: C3Context) => {
 			: []),
 	];
 
-	const result = await runCommand(deployCmd, {
-		silent: true,
+	const outputFile = join(
+		await mkdtemp(join(tmpdir(), "c3-wrangler-deploy-")),
+		"output.json",
+	);
+
+	await runCommand(deployCmd, {
 		cwd: ctx.project.path,
 		env: {
 			CLOUDFLARE_ACCOUNT_ID: ctx.account.id,
 			NODE_ENV: "production",
+			WRANGLER_OUTPUT_FILE_PATH: outputFile,
 		},
 		startText: "Deploying your application",
 		doneText: `${brandColor("deployed")} ${dim(
 			`via \`${quoteShellArgs(baseDeployCmd)}\``,
 		)}`,
 	});
 
-	const deployedUrlRegex = /https:\/\/.+\.(pages|workers)\.dev/;
-	const deployedUrlMatch = result.match(deployedUrlRegex);
-	if (deployedUrlMatch) {
-		ctx.deployment.url = deployedUrlMatch[0];
-	} else {
+	try {
+		const contents = readFile(outputFile);
+
+		const entries = contents
+			.split("\n")
+			.filter(Boolean)
+			.map((entry) => JSON.parse(entry));
+		const url: string | undefined =
+			entries.find((entry) => entry.type === "deploy")?.targets?.[0] ??
+			entries.find((entry) => entry.type === "pages-deploy")?.url;
+		const deployedUrlRegex = /https:\/\/.+\.(pages|workers)\.dev/;
+		const deployedUrlMatch = url?.match(deployedUrlRegex);
+		if (deployedUrlMatch) {
+			ctx.deployment.url = deployedUrlMatch[0];
+		} else {
+			throw new Error("Failed to find deployment url.");
+		}
+	} catch {
 		throw new Error("Failed to find deployment url.");
 	}