Add basic new streaming tail worker types #3154
Merged
+1,963
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/implement-streaming-tail-types
branch
from
731f989 to
c814e0f
Compare
anonrig
approved these changes
Nov 22, 2024
jasnell
force-pushed
the
jsnell/implement-streaming-tail-types
branch
4 times, most recently
from
2b70dce to
ef6cc65
Compare
|
Updated to ... (a) remove the use of |
fhanau
reviewed
Dec 5, 2024
fhanau
reviewed
Dec 5, 2024
jasnell
force-pushed
the
jsnell/implement-streaming-tail-types
branch
2 times, most recently
from
35ebb34 to
61a88cf
Compare
anonrig
approved these changes
Dec 5, 2024
jasnell
force-pushed
the
jsnell/implement-streaming-tail-types
branch
2 times, most recently
from
7c2bdd1 to
4d962ab
Compare
anonrig
approved these changes
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
jasnell
force-pushed
the
jsnell/implement-streaming-tail-types
branch
2 times, most recently
from
7add95d to
c648a98
Compare
fhanau
reviewed
Dec 6, 2024
fhanau
reviewed
Dec 6, 2024
fhanau
approved these changes
Dec 6, 2024
None of these depend on private state at all, for simplicity and consistency, make them all structs
Now that InvocationSpanContext is not using a stateful counter internally there's no reason for it to be refcounted. Simplify!
jasnell
force-pushed
the
jsnell/implement-streaming-tail-types
branch
from
c648a98 to
069b981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely preparation for the bigger implementation piece. Getting the basic types implemented.
I likely won't land this immediately even with sign offs. Want to progress the design a bit more first. But this lays groundwork.This should be ready to landInternal discussion: https://wiki.cfdata.org/display/~jsnell/Tail+Workers+2%3A+Streaming+Trace (sorry for those of you following along that don't have access to this)