Workerd side of python isolate pool #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Oct 16, 2024
hoodmane
reviewed
Oct 16, 2024
hoodmane
reviewed
Oct 16, 2024
danlapid
force-pushed
the
dlapid/python-pools2
branch
8 times, most recently
from
7609106 to
b3d8a00
Compare
danlapid
commented
Oct 17, 2024
src/pyodide/types/emscripten.d.ts
Outdated
| @@ -68,4 +68,8 @@ interface Module { | |||
| addRunDependency(x: string): void; | |||
| removeRunDependency(x: string): void; | |||
| noInitialRun: boolean; | |||
| setUnsafeEval(mod: typeof import('internal:unsafe-eval').default): void; | |||
There was a problem hiding this comment.
Type imports must be here instead of an import statement because we use this file as an "ambient" type declaration.
See https://stackoverflow.com/questions/39040108/import-class-in-definition-file-d-ts
danlapid
commented
Oct 17, 2024
danlapid
force-pushed
the
dlapid/python-pools2
branch
2 times, most recently
from
1deb2c2 to
e4e608b
Compare
hoodmane
reviewed
Oct 18, 2024
danlapid
force-pushed
the
dlapid/python-pools2
branch
8 times, most recently
from
bc1543a to
1a87fae
Compare
danlapid
force-pushed
the
dlapid/python-pools2
branch
2 times, most recently
from
2e46939 to
05e7568
Compare
danlapid
changed the base branch from
main
to
dlapid/ownership_cleanups_for_pools
danlapid
commented
Oct 30, 2024
danlapid
force-pushed
the
dlapid/python-pools2
branch
12 times, most recently
from
d166d95 to
97bfb3a
Compare
danlapid
force-pushed
the
dlapid/refactor_limitenforcer_workerobserver
branch
5 times, most recently
from
9a5a6ee to
550e085
Compare
Base automatically changed from
dlapid/refactor_limitenforcer_workerobserver
to
main
December 7, 2024 12:25
danlapid
force-pushed
the
dlapid/python-pools2
branch
2 times, most recently
from
9272eae to
7e32820
Compare
|
The generated output of |
danlapid
force-pushed
the
dlapid/python-pools2
branch
from
7e32820 to
d724cad
Compare
danlapid
force-pushed
the
dlapid/python-pools2
branch
from
d724cad to
c876e52
Compare
This commit moves the emscripten and pyodide initialization step to the API constructor to enable creation of python isolate pools.
dom96
approved these changes
Dec 9, 2024
| @@ -490,7 +490,7 @@ jsg::JsValue SetupEmscripten::getModule(jsg::Lock& js) { | |||
| } | |||
|
|
|||
| void SetupEmscripten::visitForGc(jsg::GcVisitor& visitor) { | |||
| visitor.visit(emscriptenRuntime.emscriptenRuntime); | |||
| visitor.visit(const_cast<EmscriptenRuntime&>(emscriptenRuntime).emscriptenRuntime); | |||
There was a problem hiding this comment.
Nit: might be worth writing a comment why this cast is necessary and why it's safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.