[nfc] Roll Rust dependencies, clean up lol_html #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Dec 10, 2024
jasnell
approved these changes
Dec 10, 2024
|
I was wondering why we hadn't cleaned up cxxbridge earlier but this breaks on Windows as usual 🙄. Based on https://github.com/cloudflare/workerd-cxx/blob/master/tools/cargo/build.rs#L9 this is likely due to missing symlinks which we might be able to patch in but this is not important enough to fight Bazel about. I'll roll back that part of the change so that this can move forward. |
fhanau
force-pushed
the
felix/121024-rust-cleanup
branch
from
8696d87 to
af08fbb
Compare
fhanau
changed the title
mikea
approved these changes
Dec 10, 2024
We do not use the Rust API directly, so we only need to depend on the C API.
fhanau
force-pushed
the
felix/121024-rust-cleanup
branch
from
af08fbb to
f8cce38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable/require some more cleanup in the upstream repo – they should be more closely aligned now.