implement node:dns module for nodejs_compat (#3183)

cloudflare · Dec 9, 2024 · 88872ff · 88872ff
1 parent 79ff507
commit 88872ff
Show file tree

Hide file tree

Showing 22 changed files with 1,776 additions and 316 deletions.
diff --git a/compile_flags.txt b/compile_flags.txt
@@ -50,6 +50,7 @@
 -isystembazel-bin/src/rust/cxx-integration/_virtual_includes/cxx-include/
 -isystembazel-bin/src/rust/cxx-integration/_virtual_includes/cxx-integration@cxx
 -isystembazel-bin/src/rust/cxx-integration-test/_virtual_includes/cxx-integration-test@cxx
+-isystembazel-bin/src/rust/dns/_virtual_includes/dns@cxx
 -D_FORTIFY_SOURCE=1
 -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES
 -D_LIBCPP_NO_ABI_TAG

diff --git a/deps/rust/Cargo.lock b/deps/rust/Cargo.lock
diff --git a/deps/rust/cargo.bzl b/deps/rust/cargo.bzl
@@ -24,6 +24,7 @@ PACKAGES = {
     "serde_json": crate.spec(version = "1"),
     "serde": crate.spec(version = "1", features = ["derive"]),
     "syn": crate.spec(version = "2"),
+    "thiserror": crate.spec(version = "2"),
     # tokio is huge, let's enable only features when we actually need them.
     "tokio": crate.spec(version = "1", default_features = False, features = ["net", "rt", "rt-multi-thread", "time"]),
     "tracing": crate.spec(version = "0", default_features = False, features = ["std"]),

diff --git a/deps/rust/crates/BUILD.bazel b/deps/rust/crates/BUILD.bazel
@@ -133,6 +133,12 @@ alias(
     tags = ["manual"],
 )
 
+alias(
+    name = "thiserror",
+    actual = "@crates_vendor__thiserror-2.0.6//:thiserror",
+    tags = ["manual"],
+)
+
 alias(
     name = "tokio",
     actual = "@crates_vendor__tokio-1.41.1//:tokio",

diff --git a/deps/rust/crates/BUILD.thiserror-2.0.6.bazel b/deps/rust/crates/BUILD.thiserror-2.0.6.bazel
@@ -0,0 +1,114 @@
+###############################################################################
+# @generated
+# DO NOT MODIFY: This file is auto-generated by a crate_universe tool. To
+# regenerate this file, run the following:
+#
+#     bazel run @//deps/rust:crates_vendor
+###############################################################################
+
+load("@rules_rust//cargo:defs.bzl", "cargo_build_script")
+load("@rules_rust//rust:defs.bzl", "rust_library")
+
+package(default_visibility = ["//visibility:public"])
+
+rust_library(
+    name = "thiserror",
+    srcs = glob(
+        include = ["**/*.rs"],
+        allow_empty = True,
+    ),
+    compile_data = glob(
+        include = ["**"],
+        allow_empty = True,
+        exclude = [
+            "**/* *",
+            ".tmp_git_root/**/*",
+            "BUILD",
+            "BUILD.bazel",
+            "WORKSPACE",
+            "WORKSPACE.bazel",
+        ],
+    ),
+    crate_features = [
+        "default",
+        "std",
+    ],
+    crate_root = "src/lib.rs",
+    edition = "2021",
+    proc_macro_deps = [
+        "@crates_vendor__thiserror-impl-2.0.6//:thiserror_impl",
+    ],
+    rustc_flags = [
+        "--cap-lints=allow",
+    ],
+    tags = [
+        "cargo-bazel",
+        "crate-name=thiserror",
+        "manual",
+        "noclippy",
+        "norustfmt",
+    ],
+    version = "2.0.6",
+    deps = [
+        "@crates_vendor__thiserror-2.0.6//:build_script_build",
+    ],
+)
+
+cargo_build_script(
+    name = "_bs",
+    srcs = glob(
+        include = ["**/*.rs"],
+        allow_empty = True,
+    ),
+    compile_data = glob(
+        include = ["**"],
+        allow_empty = True,
+        exclude = [
+            "**/* *",
+            "**/*.rs",
+            ".tmp_git_root/**/*",
+            "BUILD",
+            "BUILD.bazel",
+            "WORKSPACE",
+            "WORKSPACE.bazel",
+        ],
+    ),
+    crate_features = [
+        "default",
+        "std",
+    ],
+    crate_name = "build_script_build",
+    crate_root = "build.rs",
+    data = glob(
+        include = ["**"],
+        allow_empty = True,
+        exclude = [
+            "**/* *",
+            ".tmp_git_root/**/*",
+            "BUILD",
+            "BUILD.bazel",
+            "WORKSPACE",
+            "WORKSPACE.bazel",
+        ],
+    ),
+    edition = "2021",
+    pkg_name = "thiserror",
+    rustc_flags = [
+        "--cap-lints=allow",
+    ],
+    tags = [
+        "cargo-bazel",
+        "crate-name=thiserror",
+        "manual",
+        "noclippy",
+        "norustfmt",
+    ],
+    version = "2.0.6",
+    visibility = ["//visibility:private"],
+)
+
+alias(
+    name = "build_script_build",
+    actual = ":_bs",
+    tags = ["manual"],
+)
diff --git a/deps/rust/crates/BUILD.thiserror-impl-2.0.6.bazel b/deps/rust/crates/BUILD.thiserror-impl-2.0.6.bazel
@@ -0,0 +1,49 @@
+###############################################################################
+# @generated
+# DO NOT MODIFY: This file is auto-generated by a crate_universe tool. To
+# regenerate this file, run the following:
+#
+#     bazel run @//deps/rust:crates_vendor
+###############################################################################
+
+load("@rules_rust//rust:defs.bzl", "rust_proc_macro")
+
+package(default_visibility = ["//visibility:public"])
+
+rust_proc_macro(
+    name = "thiserror_impl",
+    srcs = glob(
+        include = ["**/*.rs"],
+        allow_empty = True,
+    ),
+    compile_data = glob(
+        include = ["**"],
+        allow_empty = True,
+        exclude = [
+            "**/* *",
+            ".tmp_git_root/**/*",
+            "BUILD",
+            "BUILD.bazel",
+            "WORKSPACE",
+            "WORKSPACE.bazel",
+        ],
+    ),
+    crate_root = "src/lib.rs",
+    edition = "2021",
+    rustc_flags = [
+        "--cap-lints=allow",
+    ],
+    tags = [
+        "cargo-bazel",
+        "crate-name=thiserror-impl",
+        "manual",
+        "noclippy",
+        "norustfmt",
+    ],
+    version = "2.0.6",
+    deps = [
+        "@crates_vendor__proc-macro2-1.0.89//:proc_macro2",
+        "@crates_vendor__quote-1.0.37//:quote",
+        "@crates_vendor__syn-2.0.87//:syn",
+    ],
+)
diff --git a/deps/rust/crates/defs.bzl b/deps/rust/crates/defs.bzl
@@ -312,6 +312,7 @@ _NORMAL_DEPENDENCIES = {
             "serde": Label("@crates_vendor__serde-1.0.215//:serde"),
             "serde_json": Label("@crates_vendor__serde_json-1.0.132//:serde_json"),
             "syn": Label("@crates_vendor__syn-2.0.87//:syn"),
+            "thiserror": Label("@crates_vendor__thiserror-2.0.6//:thiserror"),
             "tokio": Label("@crates_vendor__tokio-1.41.1//:tokio"),
             "tracing": Label("@crates_vendor__tracing-0.1.40//:tracing"),
         },
@@ -1386,6 +1387,16 @@ def crate_repositories():
         build_file = Label("@workerd//deps/rust/crates:BUILD.thiserror-1.0.69.bazel"),
     )
 
+    maybe(
+        http_archive,
+        name = "crates_vendor__thiserror-2.0.6",
+        sha256 = "8fec2a1820ebd077e2b90c4df007bebf344cd394098a13c563957d0afc83ea47",
+        type = "tar.gz",
+        urls = ["https://static.crates.io/crates/thiserror/2.0.6/download"],
+        strip_prefix = "thiserror-2.0.6",
+        build_file = Label("@workerd//deps/rust/crates:BUILD.thiserror-2.0.6.bazel"),
+    )
+
     maybe(
         http_archive,
         name = "crates_vendor__thiserror-impl-1.0.69",
@@ -1396,6 +1407,16 @@ def crate_repositories():
         build_file = Label("@workerd//deps/rust/crates:BUILD.thiserror-impl-1.0.69.bazel"),
     )
 
+    maybe(
+        http_archive,
+        name = "crates_vendor__thiserror-impl-2.0.6",
+        sha256 = "d65750cab40f4ff1929fb1ba509e9914eb756131cef4210da8d5d700d26f6312",
+        type = "tar.gz",
+        urls = ["https://static.crates.io/crates/thiserror-impl/2.0.6/download"],
+        strip_prefix = "thiserror-impl-2.0.6",
+        build_file = Label("@workerd//deps/rust/crates:BUILD.thiserror-impl-2.0.6.bazel"),
+    )
+
     maybe(
         http_archive,
         name = "crates_vendor__tokio-1.41.1",
@@ -1623,6 +1644,7 @@ def crate_repositories():
         struct(repo = "crates_vendor__serde-1.0.215", is_dev_dep = False),
         struct(repo = "crates_vendor__serde_json-1.0.132", is_dev_dep = False),
         struct(repo = "crates_vendor__syn-2.0.87", is_dev_dep = False),
+        struct(repo = "crates_vendor__thiserror-2.0.6", is_dev_dep = False),
         struct(repo = "crates_vendor__tokio-1.41.1", is_dev_dep = False),
         struct(repo = "crates_vendor__tracing-0.1.40", is_dev_dep = False),
     ]
diff --git a/justfile b/justfile
@@ -60,3 +60,7 @@ rustfmt:
 # example: just bench mimetype
 bench path:
   bazel run //src/workerd/tests:bench-{{path}}
+
+# example: just clippy dns
+clippy package="...":
+  bazel build //src/rust/{{package}} --config=lint