Merge pull request #5146 from cloudflare/felix/092025-build-cleanup

09-20-25 build cleanup

Author: fhanau

.bazelrc

@@ -36,20 +36,15 @@ import %workspace%/build/rust_lint.bazelrc
 # Prevents bazel cache invalidation when switching terminals
 build --incompatible_strict_action_env
 
-# Our dependencies (ICU, zlib, etc.) produce a lot of these warnings, so we disable them. Depending
-# on the clang version, zlib either produces warnings for -Wdeprecated-non-prototype or does not
-# have that option, so disable -Wunknown-warning-option there too.
+# Our dependencies (ICU, zlib, etc.) produce a lot of these warnings, so we disable them.
 build --per_file_copt='external@-Wno-error'
 build --per_file_copt='external@-Wno-suggest-override'
 build --per_file_copt='external/v8@-Wno-unused-function'
-build --per_file_copt='external/zlib@-Wno-unknown-warning-option,-Wno-deprecated-non-prototype'
-build --host_per_file_copt='external/zlib@-Wno-unknown-warning-option,-Wnodeprecated-non-prototype'
+build --per_file_copt='external/zlib@-Wno-deprecated-non-prototype'
+build --host_per_file_copt='external/zlib@-Wno-deprecated-non-prototype'
 build --per_file_copt=external/protobuf@-Wno-deprecated-declarations
 build --host_per_file_copt=external/protobuf@-Wno-deprecated-declarations
 
-## simdutf
-build --per_file_copt=external/simdutf@-Wno-unused-const-variable
-
 # TODO(cleanup): Causes warnings with LLVM20, fix and enable again
 build --copt=-Wno-nontrivial-memaccess
 
@@ -77,19 +72,19 @@ build:unix --per_file_copt=external/ssl@-fno-exceptions
 build:unix --per_file_copt=external/v8@-fno-exceptions
 build:unix --per_file_copt=external/ada-url@-fno-exceptions
 build:unix --per_file_copt=external/simdutf@-fno-exceptions
-build:windows --per_file_copt=external/abseil-cpp@/GX-
-build:windows --per_file_copt=external/protobuf@/GX-
-build:windows --per_file_copt=external/com_google_tcmalloc@/GX-
-build:windows --per_file_copt=external/com_googlesource_chromium_icu@/GX-
-build:windows --per_file_copt=external/perfetto@/GX-
-build:windows --per_file_copt=external/ssl@/GX-
-build:windows --per_file_copt=external/v8@/GX-
-build:windows --per_file_copt=external/ada-url@/GX-
-build:windows --per_file_copt=external/simdutf@/GX-
+build:windows --per_file_copt=external/abseil-cpp@/clang:-fno-exceptions
+build:windows --per_file_copt=external/protobuf@/clang:-fno-exceptions
+build:windows --per_file_copt=external/com_google_tcmalloc@/clang:-fno-exceptions
+build:windows --per_file_copt=external/com_googlesource_chromium_icu@/clang:-fno-exceptions
+build:windows --per_file_copt=external/perfetto@/clang:-fno-exceptions
+build:windows --per_file_copt=external/ssl@/clang:-fno-exceptions
+build:windows --per_file_copt=external/v8@/clang:-fno-exceptions
+build:windows --per_file_copt=external/ada-url@/clang:-fno-exceptions
+build:windows --per_file_copt=external/simdutf@/clang:-fno-exceptions
 
 # V8 torque is an exception from this policy, see v8 BUILD.gn.
 build:unix --per_file_copt=external/v8/src/torque@-fexceptions
-build:windows --per_file_copt=external/v8/src/torque@/GX
+build:windows --per_file_copt=external/v8/src/torque@/clang:-fexceptions
 
 # Disable relaxing all jumps during LLVM codegen under -O0, which previously led to build
 # performance improvements but makes code size worse. This will be the default in LLVM19.
@@ -215,11 +210,9 @@ build:unix --cxxopt='-Wextra' --host_cxxopt='-Wextra'
 build:unix --cxxopt='-Wunused-function' --host_cxxopt='-Wunused-function'
 build:unix --cxxopt='-Wunused-lambda-capture' --host_cxxopt='-Wunused-lambda-capture'
 build:unix --cxxopt='-Wunused-variable' --host_cxxopt='-Wunused-variable'
-build:unix --cxxopt='-Wno-strict-aliasing' --host_cxxopt='-Wno-strict-aliasing'
 build:unix --cxxopt='-Wno-sign-compare' --host_cxxopt='-Wno-sign-compare'
 build:unix --cxxopt='-Wno-unused-parameter' --host_cxxopt='-Wno-unused-parameter'
 build:unix --cxxopt='-Wno-missing-field-initializers' --host_cxxopt='-Wno-missing-field-initializers'
-build:unix --cxxopt='-Wno-ignored-qualifiers' --host_cxxopt='-Wno-ignored-qualifiers'
 build:unix --cxxopt='-Wsuggest-override'
 
 build:linux --config=unix
@@ -277,9 +270,6 @@ build:linux --copt="-fdata-sections" --host_copt="-fdata-sections"
 # On Linux, use clang lld.
 build:linux --linkopt="-fuse-ld=lld"
 
-# Disable LLVM 20 warning about unused cli argument "-c".
-build:linux --copt='-Wno-unused-command-line-argument' --copt='-Wno-unknown-warning-option' --host_copt='-Wno-unused-command-line-argument' --host_copt='-Wno-unknown-warning-option'
-
 #
 # Windows
 #
@@ -308,7 +298,6 @@ build:windows --extra_execution_platforms=//:x64_windows-clang-cl
 # workaround.
 
 build:windows_no_dbg -c opt
-build:windows_no_dbg --copt='-O0'
 build:windows_no_dbg --copt='/Od'
 build:windows_no_dbg --linkopt='/INCREMENTAL:NO'
 build:windows_no_dbg --features=-smaller_binary
@@ -381,10 +370,9 @@ build:release_windows --per_file_copt=.*capnp/rpc\.c++@/clang:-O1
 build:windows --cxxopt='/std:c++23preview' --host_cxxopt='/std:c++23preview'
 build:windows --copt='/D_CRT_USE_BUILTIN_OFFSETOF' --host_copt='/D_CRT_USE_BUILTIN_OFFSETOF'
 build:windows --copt='/DWIN32_LEAN_AND_MEAN' --host_copt='/DWIN32_LEAN_AND_MEAN'
-build:windows --copt='-Wno-microsoft-unqualified-friend' --host_copt='-Wno-microsoft-unqualified-friend'
 # The `/std:c++23preview` argument is unused during BoringSSL compilation and we don't
 # want a warning when compiling each file.
-build:windows --copt='-Wno-unused-command-line-argument' --host_copt='-Wno-unused-command-line-argument'
+build:windows --per_file_copt=external/ssl@-Wno-unused-command-line-argument --host_per_file_copt=external/ssl@-Wno-unused-command-line-argument
 
 # MSVC disappointingly sets __cplusplus to 199711L by default. Defining /Zc:__cplusplus makes it
 # set the correct value. We currently don't check __cplusplus, but some dependencies do.

build/BUILD.simdutf

@@ -7,7 +7,10 @@ cc_library(
         # CPUs is no longer needed.
         "@platforms//cpu:x86_64": ["-msse4.2"],
         "//conditions:default": [],
-    }) + ["-Wno-unused-function"],
+    }) + [
+        "-Wno-unused-function",
+        "-Wno-unused-const-variable",
+    ],
     defines = ["SIMDUTF_ATOMIC_REF"],
     visibility = ["//visibility:public"],
 )

build/cc_ast_dump.bzl

@@ -26,7 +26,8 @@ def _cc_ast_dump_impl(ctx):
         feature_configuration = feature_configuration,
         source_file = ctx.file.src.path,
         output_file = None,
-        user_compile_flags = ["-Xclang", "-ast-dump=json", "-fsyntax-only"] + ctx.fragments.cpp.copts + ctx.fragments.cpp.cxxopts,
+        # clang 19 complains about '-c' being unused
+        user_compile_flags = ["-Wno-unused-command-line-argument", "-Xclang", "-ast-dump=json", "-fsyntax-only"] + ctx.fragments.cpp.copts + ctx.fragments.cpp.cxxopts,
         include_directories = cc_info.compilation_context.includes,
         quote_include_directories = cc_info.compilation_context.quote_includes,
         system_include_directories = cc_info.compilation_context.system_includes,

build/kj_test.bzl

@@ -21,7 +21,11 @@ def kj_test(
             "@platforms//os:linux": 0,
             "//conditions:default": 1,
         }),
+        # For test binaries, reduce thinLTO optimizations and inlining to speed up linking. This
+        # only has an effect if thinLTO is enabled. Also apply dead_strip on macOS to manage binary
+        # sizes.
         linkopts = select({
+            "@platforms//os:linux": ["-Wl,--lto-O1", "-Wl,-mllvm,-import-instr-limit=5"],
             "@//:use_dead_strip": ["-Wl,-dead_strip", "-Wl,-no_exported_symbols"],
             "//conditions:default": [""],
         }),

build/wd_cc_embed.bzl

@@ -81,7 +81,10 @@ extern size_t {embed_name}_size;
         additional_compiler_inputs = [src],
         conlyopts = select({
             "@platforms//os:windows": [
-                "/std:c26",
+                # Windows doesn't recognize C23 yet, and complains about C23 extensions even with clatest.
+                "/std:clatest",
+                "-Wno-c23-extensions",
+                "-Wno-unused-command-line-argument",
                 "/clang:--embed-dir=" + workspace_root + embed_package,
                 "/clang:--embed-dir=$(GENDIR)/" + workspace_root + embed_package,
             ],

compile_flags.txt

@@ -12,7 +12,7 @@
 -Iexternal/codspeed/google_benchmark/include/
 -Iexternal/perfetto/include/
 -Iexternal/perfetto/include/perfetto/base/build_configs/bazel/
--Iexternal/ssl/include
+-Iexternal/boringssl+/include
 -Iexternal/ncrypto/include
 -isystembazel-bin/external/sqlite3
 -Isrc
@@ -121,10 +121,8 @@
 -Wextra
 -Wno-builtin-macro-redefined
 -Wno-free-nonheap-object
--Wno-ignored-qualifiers
 -Wno-missing-field-initializers
 -Wno-sign-compare
--Wno-strict-aliasing
 -Wno-unused-parameter
 -Wself-assign
 -Wthread-safety

doxyfile

@@ -1199,10 +1199,8 @@ CLANG_OPTIONS          = -std=c++23     \
                          -Wextra \
                          -Wno-builtin-macro-redefined \
                          -Wno-free-nonheap-object \
-                         -Wno-ignored-qualifiers \
                          -Wno-missing-field-initializers \
                          -Wno-sign-compare \
-                         -Wno-strict-aliasing \
                          -Wno-unused-parameter \
                          -Wself-assign \
                          -Wthread-safety \

src/workerd/api/blob.h

@@ -10,6 +10,7 @@
 namespace workerd::api {
 
 class ReadableStream;
+class File;
 
 // An implementation of the Web Platform Standard Blob API
 class Blob: public jsg::Object {
@@ -112,7 +113,8 @@ class Blob: public jsg::Object {
   }
 
   class BlobInputStream;
-  friend class File;
+  // this could just be "friend File;", but clang-cl wants to see the qualified name here.
+  friend class ::workerd::api::File;
 };
 
 // An implementation of the Web Platform Standard File API

src/workerd/api/node/BUILD.bazel

@@ -18,6 +18,7 @@ wd_cc_library(
 wd_cc_library(
     name = "node",
     srcs = [
+        "async-hooks.c++",
         "crypto.c++",
         "crypto-keys.c++",
         "diagnostics-channel.c++",
@@ -28,6 +29,7 @@ wd_cc_library(
         "zlib-util.c++",
     ],
     hdrs = [
+        "async-hooks.h",
         "crypto.h",
         "diagnostics-channel.h",
         "module.h",
@@ -54,15 +56,13 @@ wd_cc_library(
 wd_cc_library(
     name = "node-core",
     srcs = [
-        "async-hooks.c++",
         "buffer.c++",
         "dns.c++",
         "i18n.c++",
         "sqlite.c++",
         "url.c++",
     ],
     hdrs = [
-        "async-hooks.h",
         "buffer.h",
         "buffer-string-search.h",
         "dns.h",
@@ -81,11 +81,11 @@ wd_cc_library(
     ],
     visibility = ["//visibility:public"],
     deps = [
-        # Do not add the io target here – this target is intended for code that does not depend on
-        # it, move files to the main node target if needed.
+        # Please do not add //src/workerd/io here – this target is intended for code that does not
+        # depend on it, move files to the main node target if needed. That way, the files here don't
+        # need to be rebuilt if there are changes to io.
         "//src/workerd/io:compatibility-date_capnp",
         "//src/workerd/jsg",
-        "//src/workerd/io",
         "//src/workerd/util:mimetype",
         ":exceptions",
     ],