Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues reported by linter #7

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Address issues reported by linter #7

merged 4 commits into from
Mar 18, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Mar 2, 2022

Changes:

  • Specifying augmented type for mock CryptoKey
  • Specifying types in group module.
  • Increasing number of statements/lines allowed per function
  • Changing eslint one-var rule to never.

Fixes #4
Fixes #5
Fixes #6

@armfazh armfazh requested a review from cdrubin March 2, 2022 02:49
@armfazh armfazh self-assigned this Mar 2, 2022
@armfazh armfazh mentioned this pull request Mar 18, 2022
Merged
@armfazh armfazh merged commit 79c9183 into cloudflare:main Mar 18, 2022
@armfazh armfazh deleted the addressLinter branch March 18, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrubin cdrubin cdrubin approved these changes

Assignees

@armfazh armfazh

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@armfazh @cdrubin