Updates test vectors to draft-v20. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenta
reviewed
Feb 2, 2023
Co-authored-by: Luke Valenta <[email protected]>
|
Looks like v20 is out as of today: https://datatracker.ietf.org/doc/draft-irtf-cfrg-voprf/. Should we be upgrading to that instead? |
|
@lukevalenta Nah, -20 is just an editorial change. EDIT: Updating the references to point to -20 is fine though! |
lukevalenta
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Confirmed that the text vectors match https://github.com/cfrg/draft-irtf-cfrg-voprf/blob/main/poc/vectors/allVectors.json.
Looks good to me pending updating the links to v20 (non-blocking).
armfazh
changed the title
|
Thanks for the review, I just updated the references to v20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.