Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher fails to see subdirectories as of 2.1.0 #153

Closed
huw opened this issue Jan 18, 2022 · 3 comments
Closed

Watcher fails to see subdirectories as of 2.1.0 #153

huw opened this issue Jan 18, 2022 · 3 comments

Comments

@huw
Copy link
Contributor

huw commented Jan 18, 2022

I have a file tree that looks like this:

repo
|-dist
  |-index.js
|-src
  |-subdir
    |-file.ts
  |-index.ts
|-wrangler.toml
|-package.json
|-tsconfig.json

In v2.0.0, miniflare --watch would pick up changes to src/subdir/file.ts and reload the worker appropriately. In v2.1.0, miniflare --watch only picks up changes to direct children of src (such as src/index.ts).

miniflare --watch --verbose shows:

…
[mf:dbg] - Watch: true
…
[mf:dbg] - Build Watch Paths: src
…
[mf:dbg] Watching .env, dist/index.js, src, wrangler.toml...
…

And this occurs on the default config. I’ve tried this with an MWE and it still shows.

This is running on a Debian VS Codespaces instance, if that helps.

@mrbbot
Copy link
Contributor

mrbbot commented Jan 18, 2022

Hey! 👋 Thanks for raising this. Would you be able to post your logs with the NODE_DEBUG=mf-watch environment variable set? This will enable very-verbose logging for the watcher.

@mrbbot mrbbot closed this as completed in b3cd7d1 Jan 18, 2022
@mrbbot
Copy link
Contributor

mrbbot commented Jan 18, 2022

Hey! 👋 I've just released version 2.2.0 including a fix for this. You can find the full changelog here.

@ibrahimjelliti
Copy link

broken on 2.4.0, downgraded to 2.2.0, and still not reloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants