Failed to parse URL from [object Object] #144
Comments
|
Are you using Yarn PnP? This happens for me with Yarn PnP. |
|
@DJtheRedstoner Yes. I filed another issue along those lines too. #143 This is a pretty major regression, surprised nobody tested this. |
|
Hey everyone! 👋 I've spent most the afternoon trying to debug this and I haven't been able to fix it. Yarn PnP seems pretty cool, but to me at least, it's very opaque and hard to debug. I'll share what I've found so far. I would be very happy to accept a PR fixing this, but I don't think I'm going to spend any more time myself trying to fix this, as it works with The problem is caused by this line: miniflare/packages/core/src/standards/http.ts Lines 372 to 373 in 541e218 It looks like 2 versions of This can be seen in the
|
mrbbot
added
bug
|
Thanks for looking into this @mrbbot. I've pinged the yarn devs and one has offered to look at this and requested a bare minimal test project. Added it here: https://github.com/lookfirst/miniflare2-fail clone, yarn install, yarn dev As an aside, I don't think 'wontfix' is the right tag for this. It should get fixed. |
|
Thank you! 🙂 You're right, the |
|
@mrbbot Based on the If you run the following command in the repro @lookfirst provided you can see that the following list of packages doesn't provide Alternatively you can also get that list from yarn explain peer-requirements | grep "doesn't" | grep @miniflare/core | grep -v "@types"
➤ YN0000: p1b6c0 → @miniflare/cache@npm:2.0.0 doesn't provide @miniflare/watcher to @miniflare/core
➤ YN0000: p17fca → @miniflare/durable-objects@npm:2.0.0 doesn't provide @miniflare/watcher to @miniflare/core
➤ YN0000: p676bc → @miniflare/html-rewriter@npm:2.0.0 doesn't provide @miniflare/watcher to @miniflare/core
➤ YN0000: p49228 → @miniflare/http-server@npm:2.0.0 doesn't provide @miniflare/watcher to @miniflare/core
➤ YN0000: p8ea86 → @miniflare/scheduler@npm:2.0.0 doesn't provide @miniflare/watcher to @miniflare/core
➤ YN0000: p8cbaa → @miniflare/web-sockets@npm:2.0.0 doesn't provide @miniflare/watcher to @miniflare/core |
|
Probably easiest to just move watcher into a dependency for core. @mrbbot need a PR? |
|
Just fixed! 👍 That's exactly what I did. 🙂 Thanks @merceyz for explaining this, that does make sense. |
|
Hey! 👋 I've just released version |
|
Confirmed with my production worker. Thanks! |
|
@mrbbot The issue got back to life with the latest |
|
I just upgrade to 2.4.0 and now I have this issue too. |
|
@mrbbot Still can't upgrade to 2.4.0 either. @eric-naguras 2.3.0 introduced the issue, 2.2.x should work well. |
|
Hey @rennokki! Which package manager are you using? Assuming |
|
@mrbbot I did exactly what you suggested (deleting all dependencies and reinstall) and that solved the issue. |
|
Actually, it worked. :D |
I just tried to upgrade to v2 and hit
/, which I have mapped to a 404 (but any of my previously working endpoints fail as well). I have no idea why this is failing now.My code is dead simple:
The error is:
Seems like there are two bits here... a problem with miniflare and giving feedback to your upstream dependency undici to display a more helpful error than trying to blindly concat a string and an object.
The text was updated successfully, but these errors were encountered: