Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use neater serde_with::skip_serializing_none logic #31

Merged
merged 2 commits into from
Aug 20, 2019
Merged

use neater serde_with::skip_serializing_none logic #31

merged 2 commits into from
Aug 20, 2019

Conversation

gabbifish
Copy link
Contributor

This PR is a follow-up to @sssilver's comments on #28 :)

sssilver
sssilver reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@sssilver sssilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be lovely if this PR included all the other types where we do the #[serde(skip_serializing_if = "Option::is_none")] acrobatics for every Option.

@gabbifish
Copy link
Contributor Author

@sssilver Done! No more #[serde(skip_serializing_if = "Option::is_none")] :)

@gabbifish gabbifish merged commit 7f060dc into cloudflare:master Aug 20, 2019
@gabbifish gabbifish deleted the add-workers-kv-bulk-upload branch August 20, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchalmers adamchalmers adamchalmers approved these changes

@sssilver sssilver sssilver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabbifish @sssilver @adamchalmers