Add support for Workers KV bulk upload API endpoint #28
Conversation
gabbifish
force-pushed
the
add-workers-kv-bulk-upload
branch
from
93d7c6f to
723770b
Compare
gabbifish
force-pushed
the
add-workers-kv-bulk-upload
branch
from
88abdd4 to
3d0164a
Compare
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub expiration_ttl: Option<i32>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub base64: Option<bool>, |
There was a problem hiding this comment.
We should be leveraging mechanisms discussed in dtolnay/request-for-implementation#18 for skip_serializing_if and Option
There was a problem hiding this comment.
This is borat voice VERY NaIIICE (I added it in https://github.com/cloudflare/cloudflare-rs/pull/31/files)
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub expiration: Option<i32>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub expiration_ttl: Option<i32>, |
There was a problem hiding this comment.
In other places (CreateDnsRecordParams) TTL field has been defined as u32, which seems more meaningful considering a negative TTL doesn't make sense.
There was a problem hiding this comment.
you may want to join the discussion here
There was a problem hiding this comment.
I chatted with the KV team and apparently they use i64! I will use that instead (its max value is much larger than u32).
| pub key: String, | ||
| pub value: String, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub expiration: Option<i32>, |
There was a problem hiding this comment.
It holds an expiration date (seconds since epoch)
This PR adds support for the Workers KV bulk upload API endpoint: https://api.cloudflare.com/#workers-kv-namespace-write-multiple-key-value-pairs.
It is used by cloudflare/wrangler-legacy#445