Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution question for wrapper for RabbitmQ and Redis #610

Open
amit2103 opened this issue Mar 20, 2024 · 8 comments
Open

Contribution question for wrapper for RabbitmQ and Redis #610

amit2103 opened this issue Mar 20, 2024 · 8 comments

Comments

@amit2103
Copy link

Hi,

We want to contribute a sdk wrapper for RabbitMQ and Redis pub sub. We think these two are very widely used and will be useful for a lot of developers. Just wanted to verify are there any constraints if we do so ? Can we go ahead and create the PR's

@ignitewala
Copy link

it will be a great help for many

@pierDipi
Copy link
Member

pierDipi commented Mar 25, 2024

I believe for redis we will need a protocol binding in the specification first https://github.com/cloudevents/spec

For RabbitMQ, from my understanding it can support AMQP 1.0 with a plugin https://www.rabbitmq.com/docs/protocols and AMQP 1.0 is part of the spec https://github.com/cloudevents/spec/blob/main/cloudevents/bindings/amqp-protocol-binding.md, are you interesting in RabbitMQ using which protocol and protocol version ?

@pierDipi
Copy link
Member

cc @ikavgo

@ikavgo
Copy link

ikavgo commented Mar 25, 2024

thanks for pinging. RabbitMQ supports natively AMQP 0.9.1 and 1.0 as well as MQTT up to 5 and STOMP.

@amit2103
Copy link
Author

Thanks , then perhaps we should start with the redis.
So first step is to create a protocol binding :- https://github.com/cloudevents/spec
and then code to actually implement it ?

@pierDipi
Copy link
Member

thanks for pinging. RabbitMQ supports natively AMQP 0.9.1 and 1.0 as well as MQTT up to 5 and STOMP.

@amit2103 given this from Iliia, I guess AMQP with proton library could be already used for RabbitMQ https://github.com/cloudevents/sdk-java/tree/main/amqp or are you looking from something else/more?

@pierDipi
Copy link
Member

Thanks , then perhaps we should start with the redis. So first step is to create a protocol binding :- https://github.com/cloudevents/spec and then code to actually implement it ?

Yes, for the https://github.com/cloudevents/spec I would create an issue as well so that people can comment on it too

@amit2103
Copy link
Author

Sounds good :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants