Fix PyPy 2 build #116
Merged
Fix PyPy 2 build #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
force-pushed
the
mo.fix_pypy2_build
branch
from
e7b9339
to
16561f7
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix the build failure for PyPy 2
This wasn't noticed as part of v2.2.0, since that version of PyPy hadn't yet been released (it had been merged, but not released).
What approach did you choose and why?
The check for whether PyPy supported the cPython 3.7's Timezone API was insufficient. It was just checking the PyPy version number, which is something that both PyPy 2 and PyPy 3 share.
We also still need to check the Python version.
What should reviewers focus on?
🤷
The impact of these changes
Builds will once again work for PyPy 2.
Testing
...