Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special reducers don't preserve user-defined names #1891

Open
RReverser opened this issue Oct 23, 2024 · 0 comments
Open

Special reducers don't preserve user-defined names #1891

RReverser opened this issue Oct 23, 2024 · 0 comments
Assignees
Labels
abi-break A PR that makes an ABI breaking change release-1.0

Comments

@RReverser
Copy link
Member

As per recent API revamp proposal, special reducers attached to init/client_connected/client_disconnected events should preserve user-provided names and use the V9 moduledef out-of-band signal to indicate the lifecycle event it's attached to.

I'm working on the C# counterpart of this (V8 -> V9 migration), but I noticed that Rust implementation of the bindings macro, which already supports V9 moduledef, doesn't preserve the reducer names either.

cc @gefjon

@kazimuth kazimuth self-assigned this Oct 23, 2024
@kazimuth kazimuth added abi-break A PR that makes an ABI breaking change release-1.0 labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break A PR that makes an ABI breaking change release-1.0
Projects
None yet
Development

No branches or pull requests

2 participants