diff --git a/benchmarks/src/test/java/org/apache/druid/benchmark/query/CachingClusteredClientBenchmark.java b/benchmarks/src/test/java/org/apache/druid/benchmark/query/CachingClusteredClientBenchmark.java index a127a174b52f..e38ee8862dcb 100644 --- a/benchmarks/src/test/java/org/apache/druid/benchmark/query/CachingClusteredClientBenchmark.java +++ b/benchmarks/src/test/java/org/apache/druid/benchmark/query/CachingClusteredClientBenchmark.java @@ -104,7 +104,6 @@ import org.apache.druid.segment.generator.GeneratorBasicSchemas; import org.apache.druid.segment.generator.GeneratorSchemaInfo; import org.apache.druid.segment.generator.SegmentGenerator; -import org.apache.druid.segment.join.JoinableFactoryWrapperTest; import org.apache.druid.server.QueryStackTests; import org.apache.druid.server.coordination.ServerType; import org.apache.druid.server.metrics.NoopServiceEmitter; @@ -343,7 +342,6 @@ public boolean useParallelMergePool() }, forkJoinPool, QueryStackTests.DEFAULT_NOOP_SCHEDULER, - JoinableFactoryWrapperTest.NOOP_JOINABLE_FACTORY_WRAPPER, new NoopServiceEmitter() ); } diff --git a/extensions-contrib/moving-average-query/src/test/java/org/apache/druid/query/movingaverage/MovingAverageQueryTest.java b/extensions-contrib/moving-average-query/src/test/java/org/apache/druid/query/movingaverage/MovingAverageQueryTest.java index f8de4263072b..223048200f59 100644 --- a/extensions-contrib/moving-average-query/src/test/java/org/apache/druid/query/movingaverage/MovingAverageQueryTest.java +++ b/extensions-contrib/moving-average-query/src/test/java/org/apache/druid/query/movingaverage/MovingAverageQueryTest.java @@ -69,7 +69,6 @@ import org.apache.druid.query.planning.DataSourceAnalysis; import org.apache.druid.query.timeseries.TimeseriesQuery; import org.apache.druid.query.timeseries.TimeseriesResultValue; -import org.apache.druid.segment.join.JoinableFactoryWrapper; import org.apache.druid.segment.join.MapJoinableFactory; import org.apache.druid.server.ClientQuerySegmentWalker; import org.apache.druid.server.QueryStackTests; @@ -366,7 +365,6 @@ public long getMaxQueuedBytes() new BrokerParallelMergeConfig(), ForkJoinPool.commonPool(), QueryStackTests.DEFAULT_NOOP_SCHEDULER, - new JoinableFactoryWrapper(new MapJoinableFactory(ImmutableSet.of(), ImmutableMap.of())), new NoopServiceEmitter() ); diff --git a/extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java b/extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java index 6419d80074c8..136fb0f7a1f6 100644 --- a/extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java +++ b/extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorSpecTest.java @@ -30,10 +30,10 @@ import org.apache.druid.indexing.overlord.supervisor.SupervisorStateManagerConfig; import org.apache.druid.jackson.DefaultObjectMapper; import org.apache.druid.java.util.emitter.service.ServiceEmitter; +import org.apache.druid.java.util.metrics.DruidMonitorSchedulerConfig; import org.apache.druid.math.expr.ExprMacroTable; import org.apache.druid.query.expression.LookupEnabledTestExprMacroTable; import org.apache.druid.segment.incremental.RowIngestionMetersFactory; -import org.apache.druid.java.util.metrics.DruidMonitorSchedulerConfig; import org.apache.druid.server.metrics.NoopServiceEmitter; import org.junit.Assert; import org.junit.Test; diff --git a/processing/src/main/java/org/apache/druid/guice/ConfigProvider.java b/processing/src/main/java/org/apache/druid/guice/ConfigProvider.java index 538f2a61375e..66cc6261c9f3 100644 --- a/processing/src/main/java/org/apache/druid/guice/ConfigProvider.java +++ b/processing/src/main/java/org/apache/druid/guice/ConfigProvider.java @@ -31,6 +31,7 @@ /** * */ +@Deprecated public class ConfigProvider implements Provider { private static final Logger log = new Logger(ConfigProvider.class); @@ -40,11 +41,6 @@ public static void bind(Binder binder, Class clazz) binder.bind(clazz).toProvider(of(clazz)).in(LazySingleton.class); } - public static void bind(Binder binder, Class clazz, Map replacements) - { - binder.bind(clazz).toProvider(of(clazz, replacements)).in(LazySingleton.class); - } - public static Provider of(Class clazz) { return of(clazz, null); diff --git a/server/src/main/java/org/apache/druid/client/CachingClusteredClient.java b/server/src/main/java/org/apache/druid/client/CachingClusteredClient.java index 16ab97843881..19df276344ef 100644 --- a/server/src/main/java/org/apache/druid/client/CachingClusteredClient.java +++ b/server/src/main/java/org/apache/druid/client/CachingClusteredClient.java @@ -75,7 +75,6 @@ import org.apache.druid.query.filter.DimFilterUtils; import org.apache.druid.query.planning.DataSourceAnalysis; import org.apache.druid.query.spec.QuerySegmentSpec; -import org.apache.druid.segment.join.JoinableFactoryWrapper; import org.apache.druid.server.QueryResource; import org.apache.druid.server.QueryScheduler; import org.apache.druid.server.coordination.DruidServerMetadata; @@ -127,7 +126,6 @@ public class CachingClusteredClient implements QuerySegmentWalker private final BrokerParallelMergeConfig parallelMergeConfig; private final ForkJoinPool pool; private final QueryScheduler scheduler; - private final JoinableFactoryWrapper joinableFactoryWrapper; private final ServiceEmitter emitter; @Inject @@ -142,7 +140,6 @@ public CachingClusteredClient( BrokerParallelMergeConfig parallelMergeConfig, @Merging ForkJoinPool pool, QueryScheduler scheduler, - JoinableFactoryWrapper joinableFactoryWrapper, ServiceEmitter emitter ) { @@ -156,7 +153,6 @@ public CachingClusteredClient( this.parallelMergeConfig = parallelMergeConfig; this.pool = pool; this.scheduler = scheduler; - this.joinableFactoryWrapper = joinableFactoryWrapper; this.emitter = emitter; if (cacheConfig.isQueryCacheable(Query.GROUP_BY) && (cacheConfig.isUseCache() || cacheConfig.isPopulateCache())) { diff --git a/server/src/test/java/org/apache/druid/client/CachingClusteredClientFunctionalityTest.java b/server/src/test/java/org/apache/druid/client/CachingClusteredClientFunctionalityTest.java index 35b03b70c2af..89cb2d76f812 100644 --- a/server/src/test/java/org/apache/druid/client/CachingClusteredClientFunctionalityTest.java +++ b/server/src/test/java/org/apache/druid/client/CachingClusteredClientFunctionalityTest.java @@ -47,7 +47,6 @@ import org.apache.druid.query.aggregation.CountAggregatorFactory; import org.apache.druid.query.context.ResponseContext; import org.apache.druid.query.planning.DataSourceAnalysis; -import org.apache.druid.segment.join.JoinableFactoryWrapperTest; import org.apache.druid.server.QueryStackTests; import org.apache.druid.server.coordination.ServerType; import org.apache.druid.server.metrics.NoopServiceEmitter; @@ -320,6 +319,12 @@ public long getMaxQueuedBytes() }, new BrokerParallelMergeConfig() { + @Override + public boolean useParallelMergePool() + { + return true; + } + @Override public int getParallelism() { @@ -336,7 +341,6 @@ public int getDefaultMaxQueryParallelism() }, ForkJoinPool.commonPool(), QueryStackTests.DEFAULT_NOOP_SCHEDULER, - JoinableFactoryWrapperTest.NOOP_JOINABLE_FACTORY_WRAPPER, new NoopServiceEmitter() ); } diff --git a/server/src/test/java/org/apache/druid/client/CachingClusteredClientPerfTest.java b/server/src/test/java/org/apache/druid/client/CachingClusteredClientPerfTest.java index 29ea0e3ffdc0..6270f3685406 100644 --- a/server/src/test/java/org/apache/druid/client/CachingClusteredClientPerfTest.java +++ b/server/src/test/java/org/apache/druid/client/CachingClusteredClientPerfTest.java @@ -49,7 +49,6 @@ import org.apache.druid.query.spec.MultipleSpecificSegmentSpec; import org.apache.druid.query.spec.QuerySegmentSpec; import org.apache.druid.segment.TestHelper; -import org.apache.druid.segment.join.JoinableFactoryWrapperTest; import org.apache.druid.server.QueryScheduler; import org.apache.druid.server.coordination.ServerManagerTest; import org.apache.druid.server.coordination.ServerType; @@ -139,7 +138,6 @@ public void testGetQueryRunnerForSegments_singleIntervalLargeSegments() Mockito.mock(BrokerParallelMergeConfig.class), ForkJoinPool.commonPool(), queryScheduler, - JoinableFactoryWrapperTest.NOOP_JOINABLE_FACTORY_WRAPPER, new NoopServiceEmitter() ); diff --git a/server/src/test/java/org/apache/druid/client/CachingClusteredClientTest.java b/server/src/test/java/org/apache/druid/client/CachingClusteredClientTest.java index a50df6808012..0ebd441360ea 100644 --- a/server/src/test/java/org/apache/druid/client/CachingClusteredClientTest.java +++ b/server/src/test/java/org/apache/druid/client/CachingClusteredClientTest.java @@ -121,7 +121,6 @@ import org.apache.druid.query.topn.TopNQueryQueryToolChest; import org.apache.druid.query.topn.TopNResultValue; import org.apache.druid.segment.TestHelper; -import org.apache.druid.segment.join.JoinableFactoryWrapperTest; import org.apache.druid.server.QueryScheduler; import org.apache.druid.server.ServerTestHelper; import org.apache.druid.server.coordination.ServerType; @@ -2831,18 +2830,24 @@ public long getMaxQueuedBytes() }, new BrokerParallelMergeConfig() { + @Override + public boolean useParallelMergePool() + { + return true; + } + @Override public int getParallelism() { // fixed so same behavior across all test environments - return 4; + return 1; } @Override public int getDefaultMaxQueryParallelism() { // fixed so same behavior across all test environments - return 4; + return 1; } }, ForkJoinPool.commonPool(), @@ -2852,7 +2857,6 @@ public int getDefaultMaxQueryParallelism() NoQueryLaningStrategy.INSTANCE, new ServerConfig() ), - JoinableFactoryWrapperTest.NOOP_JOINABLE_FACTORY_WRAPPER, new NoopServiceEmitter() ); } diff --git a/server/src/test/java/org/apache/druid/query/QueryRunnerBasedOnClusteredClientTestBase.java b/server/src/test/java/org/apache/druid/query/QueryRunnerBasedOnClusteredClientTestBase.java index 843a4b031497..308427d40fa4 100644 --- a/server/src/test/java/org/apache/druid/query/QueryRunnerBasedOnClusteredClientTestBase.java +++ b/server/src/test/java/org/apache/druid/query/QueryRunnerBasedOnClusteredClientTestBase.java @@ -49,7 +49,6 @@ import org.apache.druid.segment.generator.GeneratorBasicSchemas; import org.apache.druid.segment.generator.GeneratorSchemaInfo; import org.apache.druid.segment.generator.SegmentGenerator; -import org.apache.druid.segment.join.JoinableFactoryWrapperTest; import org.apache.druid.server.QueryStackTests; import org.apache.druid.server.metrics.NoopServiceEmitter; import org.apache.druid.timeline.DataSegment; @@ -108,7 +107,6 @@ protected QueryRunnerBasedOnClusteredClientTestBase() { conglomerate = QueryStackTests.createQueryRunnerFactoryConglomerate( CLOSER, - USE_PARALLEL_MERGE_POOL_CONFIGURED, () -> TopNQueryConfig.DEFAULT_MIN_TOPN_THRESHOLD ); @@ -145,7 +143,6 @@ public void setupTestBase() QueryStackTests.getParallelMergeConfig(USE_PARALLEL_MERGE_POOL_CONFIGURED), ForkJoinPool.commonPool(), QueryStackTests.DEFAULT_NOOP_SCHEDULER, - JoinableFactoryWrapperTest.NOOP_JOINABLE_FACTORY_WRAPPER, new NoopServiceEmitter() ); servers = new ArrayList<>(); diff --git a/server/src/test/java/org/apache/druid/server/QueryStackTests.java b/server/src/test/java/org/apache/druid/server/QueryStackTests.java index 540cf0a57ae6..69305adc12db 100644 --- a/server/src/test/java/org/apache/druid/server/QueryStackTests.java +++ b/server/src/test/java/org/apache/druid/server/QueryStackTests.java @@ -203,10 +203,7 @@ public boolean useParallelMergePool() } }; } - public static DruidProcessingConfig getProcessingConfig( - boolean useParallelMergePoolConfigured, - final int mergeBuffers - ) + public static DruidProcessingConfig getProcessingConfig(final int mergeBuffers) { return new DruidProcessingConfig() { @@ -245,27 +242,17 @@ public int getNumMergeBuffers() */ public static QueryRunnerFactoryConglomerate createQueryRunnerFactoryConglomerate(final Closer closer) { - return createQueryRunnerFactoryConglomerate(closer, true, () -> TopNQueryConfig.DEFAULT_MIN_TOPN_THRESHOLD); - } - - public static QueryRunnerFactoryConglomerate createQueryRunnerFactoryConglomerate( - final Closer closer, - final Supplier minTopNThresholdSupplier - ) - { - return createQueryRunnerFactoryConglomerate(closer, true, minTopNThresholdSupplier); + return createQueryRunnerFactoryConglomerate(closer, () -> TopNQueryConfig.DEFAULT_MIN_TOPN_THRESHOLD); } public static QueryRunnerFactoryConglomerate createQueryRunnerFactoryConglomerate( final Closer closer, - final boolean useParallelMergePoolConfigured, final Supplier minTopNThresholdSupplier ) { return createQueryRunnerFactoryConglomerate( closer, getProcessingConfig( - useParallelMergePoolConfigured, DEFAULT_NUM_MERGE_BUFFERS ), minTopNThresholdSupplier diff --git a/sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java b/sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java index 0881a969fc68..3467d71bb627 100644 --- a/sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java +++ b/sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java @@ -219,7 +219,7 @@ public QueryRunnerFactoryConglomerate createCongolmerate( } else { return QueryStackTests.createQueryRunnerFactoryConglomerate( resourceCloser, - QueryStackTests.getProcessingConfig(true, builder.mergeBufferCount) + QueryStackTests.getProcessingConfig(builder.mergeBufferCount) ); } }