Skip to content

Commit 8569e88

Browse files
committed
chore(config): Remove aliases from dialect completion
I thought this would be a good idea, but it makes shell completions less effective
1 parent 5984719 commit 8569e88

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

internal/config/flags/database.go

+1-15
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import (
55

66
"gabe565.com/utils/must"
77
"github.com/clevyr/kubedb/internal/completion"
8-
"github.com/clevyr/kubedb/internal/config/conftypes"
98
"github.com/clevyr/kubedb/internal/consts"
109
"github.com/clevyr/kubedb/internal/database"
1110
"github.com/clevyr/kubedb/internal/database/sqlformat"
@@ -16,20 +15,7 @@ func Dialect(cmd *cobra.Command) {
1615
cmd.PersistentFlags().String(consts.FlagDialect, "", "Database dialect. (one of "+strings.Join(database.Names(), ", ")+") (default discovered)")
1716
must.Must(cmd.RegisterFlagCompletionFunc(consts.FlagDialect,
1817
func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
19-
dbs := database.All()
20-
s := make([]string, 0, len(dbs))
21-
for _, db := range dbs {
22-
name := db.Name()
23-
s = append(s, name+"\t"+name)
24-
if aliaser, ok := db.(conftypes.DBAliaser); ok {
25-
aliases := aliaser.Aliases()
26-
for i, alias := range aliases {
27-
aliases[i] = alias + "\t" + name
28-
}
29-
s = append(s, aliases...)
30-
}
31-
}
32-
return s, cobra.ShellCompDirectiveNoFileComp
18+
return database.Names(), cobra.ShellCompDirectiveNoFileComp
3319
}),
3420
)
3521
}

0 commit comments

Comments
 (0)