update query string param construction and add test

Author: jacekradko

packages/clerk-js/src/core/resources/Token.ts

@@ -1,16 +1,17 @@
 import type { JWT, TokenJSON, TokenJSONSnapshot, TokenResource } from '@clerk/shared/types';
 
-import { decode } from '../../utils';
-import { CLERK_SKIP_CACHE } from '../constants';
-import { BaseResource } from './internal';
+import { CLERK_SKIP_CACHE } from '@/core/constants';
+import { decode } from '@/utils';
+
+import { BaseResource } from './Base';
 
 export class Token extends BaseResource implements TokenResource {
   pathRoot = 'tokens';
 
   jwt?: JWT;
 
   static async create(path: string, body: any = {}, skipCache = false): Promise<TokenResource> {
-    const search = skipCache ? { [CLERK_SKIP_CACHE]: 'true' } : undefined;
+    const search = skipCache ? `${CLERK_SKIP_CACHE}=true` : undefined;
 
     const json = (await BaseResource._fetch<TokenJSON>({
       body,

packages/clerk-js/src/core/resources/__tests__/Token.test.ts

@@ -1,10 +1,10 @@
 import type { InstanceType } from '@clerk/shared/types';
 import { afterEach, beforeEach, describe, expect, it, type Mock, vi } from 'vitest';
 
-import { mockFetch, mockNetworkFailedFetch } from '@/test/core-fixtures';
+import { mockFetch, mockJwt, mockNetworkFailedFetch } from '@/test/core-fixtures';
 import { debugLogger } from '@/utils/debug';
 
-import { SUPPORTED_FAPI_VERSION } from '../../constants';
+import { CLERK_SKIP_CACHE, SUPPORTED_FAPI_VERSION } from '../../constants';
 import { createFapiClient } from '../../fapiClient';
 import { BaseResource } from '../internal';
 import { Token } from '../Token';
@@ -44,7 +44,7 @@ describe('Token', () => {
     });
 
     describe('with offline browser and network failure', () => {
-      let warnSpy;
+      let warnSpy: ReturnType<typeof vi.spyOn>;
 
       beforeEach(() => {
         Object.defineProperty(window.navigator, 'onLine', {
@@ -103,5 +103,54 @@ describe('Token', () => {
         });
       });
     });
+
+    it('creates token successfully with valid response', async () => {
+      mockFetch(true, 200, { jwt: mockJwt });
+      BaseResource.clerk = { getFapiClient: () => createFapiClient(baseFapiClientOptions) } as any;
+
+      const token = await Token.create('/path/to/tokens', { organizationId: 'org_123' });
+
+      expect(global.fetch).toHaveBeenCalledTimes(1);
+      const [url, options] = (global.fetch as Mock).mock.calls[0];
+      expect(url.toString()).toContain('https://clerk.example.com/v1/path/to/tokens');
+      expect(url.toString()).not.toContain(CLERK_SKIP_CACHE);
+      expect(options).toMatchObject({
+        body: 'organization_id=org_123',
+        credentials: 'include',
+        method: 'POST',
+      });
+      expect(token).toBeInstanceOf(Token);
+      expect(token.jwt).toBeDefined();
+    });
+
+    it('creates token with skipCache=false by default', async () => {
+      mockFetch(true, 200, { jwt: mockJwt });
+      BaseResource.clerk = { getFapiClient: () => createFapiClient(baseFapiClientOptions) } as any;
+
+      await Token.create('/path/to/tokens');
+
+      const [url] = (global.fetch as Mock).mock.calls[0];
+      expect(url.toString()).not.toContain(CLERK_SKIP_CACHE);
+    });
+
+    it('creates token with skipCache=true and includes query parameter', async () => {
+      mockFetch(true, 200, { jwt: mockJwt });
+      BaseResource.clerk = { getFapiClient: () => createFapiClient(baseFapiClientOptions) } as any;
+
+      await Token.create('/path/to/tokens', {}, true);
+
+      const [url] = (global.fetch as Mock).mock.calls[0];
+      expect(url.toString()).toContain(`${CLERK_SKIP_CACHE}=true`);
+    });
+
+    it('creates token with skipCache=false explicitly and excludes query parameter', async () => {
+      mockFetch(true, 200, { jwt: mockJwt });
+      BaseResource.clerk = { getFapiClient: () => createFapiClient(baseFapiClientOptions) } as any;
+
+      await Token.create('/path/to/tokens', {}, false);
+
+      const [url] = (global.fetch as Mock).mock.calls[0];
+      expect(url.toString()).not.toContain(CLERK_SKIP_CACHE);
+    });
   });
 });