Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Access does not work in VC/SA in delegate mode (has a workaround) #6

Closed
x87 opened this issue Nov 9, 2021 · 1 comment
Closed
Labels
type:bug Something isn't working

Comments

@x87
Copy link
Contributor

x87 commented Nov 9, 2021

there are multiple Memory.Read/Memory.Write commands in vc.json and sa.json for both CLEO PC and CLEO Android:

https://library.sannybuilder.com/#/vc?q="READ_MEMORY"
https://library.sannybuilder.com/#/sa?q="WRITE_MEMORY"

if CLEO runs in delegate mode Memory.Read and Memory.Write use wrong opcodes (0DD8 and 0DD9), leading to the game crash.

To fix that, platform tags should be implemented: sannybuilder/library#38

Temporary solution: delete two commands from vc.json and sa.json:

,
        {
          "input": [
            {
              "name": "address",
              "type": "int"
            },
            {
              "name": "size",
              "type": "int"
            },
            {
              "name": "ib",
              "type": "bool"
            }
          ],
          "output": [
            {
              "name": "result",
              "type": "any",
              "source": "var_any"
            }
          ],
          "id": "0DD8",
          "name": "READ_MEMORY",
          "num_params": 4,
          "class": "Memory",
          "member": "Read",
          "attrs": {
            "is_overload": true,
            "is_static": true
          },
          "short_desc": "Reads a value from the game memory"
        },
        {
          "input": [
            {
              "name": "address",
              "type": "int"
            },
            {
              "name": "value",
              "type": "any"
            },
            {
              "name": "size",
              "type": "int"
            },
            {
              "name": "ib",
              "type": "bool"
            },
            {
              "name": "vp",
              "type": "bool"
            }
          ],
          "id": "0DD9",
          "name": "WRITE_MEMORY",
          "num_params": 5,
          "class": "Memory",
          "member": "Write",
          "attrs": {
            "is_overload": true,
            "is_static": true
          },
          "short_desc": "Writes a value to the game memory"
        }
@x87 x87 added the type:bug Something isn't working label Nov 9, 2021
@x87 x87 pinned this issue Nov 9, 2021
@x87 x87 changed the title Memory Access does not work on VC/SA in delegate mode (has a workaround) Memory Access does not work in VC/SA in delegate mode (has a workaround) Nov 9, 2021
@x87
Copy link
Contributor Author

x87 commented Nov 11, 2021

Fixed in v0.7.4

@x87 x87 closed this as completed Nov 11, 2021
@x87 x87 unpinned this issue Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant