Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invaild MPRIS trackId's #5795

Closed
JasonLG1979 opened this issue Jul 22, 2017 · 1 comment
Closed

Invaild MPRIS trackId's #5795

JasonLG1979 opened this issue Jul 22, 2017 · 1 comment

Comments

@JasonLG1979
Copy link

JasonLG1979 commented Jul 22, 2017

System information

Please provide information about your system and the version of Clementine used.

  • Operating System: Fedora 26
  • Clementine version: 1.3.1

Expected behaviour / actual behaviour

Expected: TrackId's should start with a reverse DNS of the player and should be unique up to the point that if you repeat a track and/or it appears multiple time in the TrackList interface it should have a different TrackId .
Example: Pithos TrackId's start with '/io/github/Pithos/TrackId/'

How you make them unique is up to you so long as that if a client uses a TrackId in a method you know what track that TrackId is referring to.

Actual: Clementine TrackId's start with '/org/mpris/MediaPlayer2/Track/' which is forbidden by spec unless you are referring to "NoTrack".

https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html#Simple-Type:Track_Id

Even if/when you fix #5794 your TrackList interface will still be broken until this is also fixed.

Steps to reproduce the problem (only for bugs)

Read the metadata of a track.

https://github.com/JasonLG1979/gnome-shell-extensions-mediaplayer/wiki/Known-Player-Bugs#clementine

@JasonLG1979
Copy link
Author

return QString("/org/mpris/MediaPlayer2/Track/%1")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant