Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs.readdir takes too damn long #2

Closed
clee opened this issue May 4, 2016 · 1 comment
Closed

fs.readdir takes too damn long #2

clee opened this issue May 4, 2016 · 1 comment

Comments

@clee
Copy link
Owner

clee commented May 4, 2016

For reference, the initial issue that I found discussing the fs.readdir problem (fs.readdir takes way too long on large directories, where "large" means "more than 10k files" at least in my testing):

nodejs/node-v0.x-archive#388

This looks like the current nodejs issue tracking support for a streaming/iterative readdir:
nodejs/node#583

And it seems like it's currently blocked on:
libuv/libuv#416

Once libuv/libuv#416 and nodejs/node#583 are both merged, we should probably move to using the streaming readdir instead for better performance.

@clee
Copy link
Owner Author

clee commented Nov 21, 2022

I should probably write some tests to confirm the performance improvement, but the entire codebase is now using the Promise-based API and should perform MUCH better now. Closed with 22decfb.

@clee clee closed this as completed Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant