Proxy event.persist() when wrapping synthetic JS events #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm resurrecting #249, as I've run into a more concrete use-case for
event.persist()
than the one that prompted #249.Since component updates are not guaranteed to be synchronous in React 16+, the optional callback for
setState
may be called asynchronously on the JS side of things. This means that doing something like passing aSyntheticEvent
to a consumer callback within that callback will result in ReactJS spitting out a big ugly warning about the event having been recycled.Without persist()
With persist()