Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-8039 Implement/Expose useMemo Hook #250

Merged
merged 7 commits into from
Jan 23, 2020
Merged

CPLAT-8039 Implement/Expose useMemo Hook #250

merged 7 commits into from
Jan 23, 2020

Conversation

sydneyjodon-wk
Copy link
Collaborator

@sydneyjodon-wk sydneyjodon-wk commented Jan 21, 2020 •
edited
Loading

Motivation

Support useMemo hook in react-dart.

Changes

  • Added useMemo function.
  • Wrote tests.

Please review: @greglittlefield-wf @aaronlademann-wf @joebingham-wk

@sydneyjodon-wk sydneyjodon-wk changed the base branch from master to 5.4.0-wip January 21, 2020 21:38
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review January 22, 2020 00:04
aaronlademann-wf
aaronlademann-wf requested changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... just some nits.

test/hooks_test.dart Outdated Show resolved Hide resolved
lib/hooks.dart Outdated Show resolved Hide resolved
example/test/function_component_test.dart Outdated Show resolved Hide resolved
example/test/function_component_test.dart Outdated Show resolved Hide resolved
test/hooks_test.dart Outdated Show resolved Hide resolved
greglittlefield-wf
greglittlefield-wf approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

aaronlademann-wf
aaronlademann-wf approved these changes Jan 23, 2020
View reviewed changes
Copy link
Collaborator

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@greglittlefield-wf greglittlefield-wf merged commit 04f8a68 into 5.4.0-wip Jan 23, 2020
@aaronlademann-wf aaronlademann-wf added this to the 5.4.0 milestone Jan 29, 2020
@aaronlademann-wf aaronlademann-wf mentioned this pull request Aug 7, 2020
Merged
@greglittlefield-wf greglittlefield-wf deleted the CPLAT-8039-useMemo-hook branch February 16, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf approved these changes

@aaronlademann-wf aaronlademann-wf aaronlademann-wf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sydneyjodon-wk @greglittlefield-wf @aaronlademann-wf