Fix dataTransfer RTE take 2 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglittlefield-wf
force-pushed
the
stable-line_datatransfer-fix
branch
from
4a79540 to
262552b
Compare
evanweible-wf
approved these changes
Oct 10, 2019
|
|
||
| // Handle dt being either a native DOM DataTransfer object or a JS object that looks like it (events.NonNativeDataTransfer). | ||
| // Casting a JS object to DataTransfer fails intermittently in dart2js, and vice-versa fails intermittently in either DDC or dart2js. | ||
| // TODO figure out when NonNativeDataTransfer is used. |
There was a problem hiding this comment.
Cut a ticket for this?
joebingham-wk
approved these changes
Oct 10, 2019
| dropEffect = 'none'; | ||
| } | ||
| // Copy these lists and ensure they're typed properly. | ||
| // todo use .cast() in Dart 2 |
There was a problem hiding this comment.
Suggested change
| // todo use .cast() in Dart 2 | |
| // TODO use .cast() in Dart 2 |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around issue in #154 that necessitated revert of #151