Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on nightly - proc-macro2 needs update | renovate not working? #4993

Closed
2 tasks done
udondan opened this issue Jul 5, 2023 · 2 comments
Closed
2 tasks done
Labels
C-bug Category: bug

Comments

@udondan
Copy link

udondan commented Jul 5, 2023

Please complete the following tasks

Rust Version

1.72.0-nightly

Clap Version

4.3.10

Minimal reproducible code

None. Installation fails

Steps to reproduce the bug with the above code

rustup default nightly
cargo add clap
cargo build

Actual Behaviour

Failing due to incomaptible outdated dependency.

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.53/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

Expected Behaviour

Working

Additional Context

proc-macro2 is a dependency of clap_derive:

cargo tree
...
│   ├── clap_derive v4.3.2 (proc-macro)
│   │   ├── heck v0.4.1
│   │   ├── proc-macro2 v1.0.53 (*)
...

The problem has been fixed in 1.0.60+ dtolnay/proc-macro2#398

The last dependabot PR for proc-macro2 had been closed without comment. I see you switched to renovate now but I wonder if it's working correctly, since I don't see any MR for that package.

Debug Output

No response

@udondan udondan added the C-bug Category: bug label Jul 5, 2023
@epage
Copy link
Member

epage commented Jul 5, 2023

As that version of proc-macro2 works fine on stable, we have no reason to require a higher minimum version of it.

If you are needing a newer proc-macro2 within your crate, you can update it via cargo update -p proc-macro2

@epage
Copy link
Member

epage commented Jul 7, 2023

As this isn't a bug with clap and without further input, I'm going to go ahead and close this. Let us know if we need to re-evaluate this!

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants