Merge pull request #1154 from kbknapp/v3-prep

v3 Prep

Author: kbknapp

Diff for: Cargo.toml

@@ -23,6 +23,7 @@ appveyor = { repository = "kbknapp/clap-rs" }
 bitflags              = "1.0"
 unicode-width         = "0.1.4"
 textwrap              = "0.9.0"
+ordermap			  = "0.3.5"
 strsim    = { version = "0.7.0",  optional = true }
 ansi_term = { version = "0.10.0",  optional = true }
 yaml-rust = { version = "0.3.5",  optional = true }

Diff for: TODO.md

@@ -0,0 +1,19 @@
+- [ ] update-todo.sh
+- [ ] src/lib.rs
+    -[ ] 578:@TODO @release @docs
+    -[ ] 580:@TODO @release @docs
+    -[ ] 583:@TODO @release @docs
+    -[ ] 592:@TODO @release @docs
+    -[ ] 598:@TODO @release @docs
+    -[ ] 608:@TODO @release @docs
+    -[ ] 610:@TODO @release @docs
+    -[ ] 614:@TODO @release @docs
+    -[ ] 616:@TODO @release @docs
+    -[ ] 619:@TODO @release @docs
+    -[ ] 623:@TODO @release @docs
+- [ ] src/app/parser.rs
+    -[ ] 678:@TODO @perf: cloning all these Apps ins't great, but since it's just displaying the help
+- [ ] src/app/mod.rs
+    -[ ] 1760:@TODO @v3-alpha @perf: should only propagate globals to subcmd we find, or for help
+- [ ] src/args/arg.rs
+    -[ ] 3545:@TODO @p2 @docs @release: write docs

Diff for: benches/01_default.rs

@@ -8,11 +8,7 @@ use clap::App;
 use test::Bencher;
 
 #[bench]
-fn build_app(b: &mut Bencher) {
-    b.iter(|| App::new("claptests"));
-}
+fn build_app(b: &mut Bencher) { b.iter(|| App::new("claptests")); }
 
 #[bench]
-fn parse_clean(b: &mut Bencher) {
-    b.iter(|| App::new("claptests").get_matches_from(vec![""]));
-}
+fn parse_clean(b: &mut Bencher) { b.iter(|| App::new("claptests").get_matches_from(vec![""])); }

Diff for: benches/02_simple.rs

@@ -20,25 +20,18 @@ macro_rules! create_app {
 }
 
 #[bench]
-fn build_app(b: &mut Bencher) {
-
-    b.iter(|| create_app!());
-}
+fn build_app(b: &mut Bencher) { b.iter(|| create_app!()); }
 
 #[bench]
 fn add_flag(b: &mut Bencher) {
-    fn build_app() -> App<'static, 'static> {
-        App::new("claptests")
-    }
+    fn build_app() -> App<'static, 'static> { App::new("claptests") }
 
     b.iter(|| build_app().arg(Arg::from_usage("-s, --some 'something'")));
 }
 
 #[bench]
 fn add_flag_ref(b: &mut Bencher) {
-    fn build_app() -> App<'static, 'static> {
-        App::new("claptests")
-    }
+    fn build_app() -> App<'static, 'static> { App::new("claptests") }
 
     b.iter(|| {
         let arg = Arg::from_usage("-s, --some 'something'");
@@ -48,18 +41,14 @@ fn add_flag_ref(b: &mut Bencher) {
 
 #[bench]
 fn add_opt(b: &mut Bencher) {
-    fn build_app() -> App<'static, 'static> {
-        App::new("claptests")
-    }
+    fn build_app() -> App<'static, 'static> { App::new("claptests") }
 
     b.iter(|| build_app().arg(Arg::from_usage("-s, --some <FILE> 'something'")));
 }
 
 #[bench]
 fn add_opt_ref(b: &mut Bencher) {
-    fn build_app() -> App<'static, 'static> {
-        App::new("claptests")
-    }
+    fn build_app() -> App<'static, 'static> { App::new("claptests") }
 
     b.iter(|| {
         let arg = Arg::from_usage("-s, --some <FILE> 'something'");
@@ -69,18 +58,14 @@ fn add_opt_ref(b: &mut Bencher) {
 
 #[bench]
 fn add_pos(b: &mut Bencher) {
-    fn build_app() -> App<'static, 'static> {
-        App::new("claptests")
-    }
+    fn build_app() -> App<'static, 'static> { App::new("claptests") }
 
     b.iter(|| build_app().arg(Arg::with_name("some")));
 }
 
 #[bench]
 fn add_pos_ref(b: &mut Bencher) {
-    fn build_app() -> App<'static, 'static> {
-        App::new("claptests")
-    }
+    fn build_app() -> App<'static, 'static> { App::new("claptests") }
 
     b.iter(|| {
         let arg = Arg::with_name("some");
@@ -89,14 +74,10 @@ fn add_pos_ref(b: &mut Bencher) {
 }
 
 #[bench]
-fn parse_clean(b: &mut Bencher) {
-    b.iter(|| create_app!().get_matches_from(vec![""]));
-}
+fn parse_clean(b: &mut Bencher) { b.iter(|| create_app!().get_matches_from(vec![""])); }
 
 #[bench]
-fn parse_flag(b: &mut Bencher) {
-    b.iter(|| create_app!().get_matches_from(vec!["myprog", "-f"]));
-}
+fn parse_flag(b: &mut Bencher) { b.iter(|| create_app!().get_matches_from(vec!["myprog", "-f"])); }
 
 #[bench]
 fn parse_option(b: &mut Bencher) {