Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extension function names to be different from method names? #23

Open
cketti opened this issue Mar 5, 2023 · 1 comment
Open

Comments

@cketti
Copy link
Owner

cketti commented Mar 5, 2023

Short of using an import alias I wasn't able to make the following work in a KMP project that has the JVM as one of its targets:

import de.cketti.codepoints.deluxe.CodePoint
import de.cketti.codepoints.deluxe.codePointAt

fun main() {
    val stringBuilder = StringBuilder().append("a")

    // Type mismatch: inferred type is Int but CodePoint was expected
    val codePoint: CodePoint = stringBuilder.codePointAt(0)
}

It looked fine in the IDE, but failed when compiling the JVM project.

Explicitly adding a StringBuilder extension function with the @kotlin.internal.HidesMembers annotation din't work either.

@file:Suppress(
    "INVISIBLE_MEMBER",
    "INVISIBLE_REFERENCE",
    "EXTENSION_SHADOWED_BY_MEMBER",
    "KotlinRedundantDiagnosticSuppress",
)
package separate.package.to.avoid.name.conflicts

import de.cketti.codepoints.deluxe.CodePoint
import de.cketti.codepoints.deluxe.codePointAt

@kotlin.internal.HidesMembers
fun StringBuilder.codePointAt(index: Int): CodePoint {
    return (this as CharSequence).codePointAt(index)
}

Changing the names of the extension functions would avoid this problem. The question is what names to chose.

@JakeWharton
Copy link
Contributor

I got nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants