Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot submit code reviews with version 1.10.1 of the Chrome extension enabled. #448

Open
griggi-ws opened this issue May 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@griggi-ws
Copy link

πŸ“ Provide detailed reproduction steps (if any)

  1. Navigate to "Files changed" of a PR
  2. Click "Review changes" and enter data in the comment body
  3. Click "Submit Review"

βœ”οΈ Expected result

Review is submitted

❌ Actual result

No effect, and this error appears in console:

An invalid form control with name='pull_request_review[body]' is not focusable. <textarea name="pull_request_review[body]" id="pull_request_review_body" placeholder="Leave a comment" aria-label="Comment body" class="js-comment-field js-paste-markdown js-task-list-field js-quick-submit form-control input-contrast comment-form-textarea js-session-resumable js-saved-reply-shortcut-comment-field" dir="auto" data-github-writer-was-required="false" required></textarea>

❓ Possible solution

This appears to be owing to a very recent change on GitHub's side of things, as I've been using this version of the extension without issue for some time - it's only been in the last two weeks or so that this issue has started.

πŸ“ƒ Other details

  • Browser: Chrome Version 113.0.5672.126
  • OS: MacOS Monterey 12.6.3

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@griggi-ws griggi-ws added the bug Something isn't working label May 23, 2023
@akosasante
Copy link

Also reported here: #443

@akosasante
Copy link

Looks like it was fixed πŸŽ‰ #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants