Created custom splice method to deal with very big number of elements #12427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…totype.splice, to deal with very big number of elements
DawidKossowski
deleted the
ck/4595-crash-after-inserting-milion-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): Fixed editor throwing
Maximum call stack size exceedederror when huge number of nodes were inserted at once into an element. Closes #12428.Additional information
Generally, the editor crashes with error "Maximum call stack size exceeded" when there are at least 200 000 elements in one paragraph and someone opens the revision history feature. This issue has been solved, however, there is still situation when browser crashes because of large content (like 1-2 mln of chars in one paragraph) and this issue cannot be fix on our side.