Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two-step caret movement activates on an inline element inside a link #937

Closed
Mgsy opened this issue Apr 6, 2018 · 5 comments · Fixed by ckeditor/ckeditor5-engine#1406
Closed

Two-step caret movement activates on an inline element inside a link #937

Mgsy opened this issue Apr 6, 2018 · 5 comments · Fixed by ckeditor/ckeditor5-engine#1406
Assignees
@oleq
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 16

Comments

@Mgsy
Copy link
Member

Mgsy commented Apr 6, 2018 •
edited
Loading

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Latest master

📋 Steps to reproduce

  1. Open the article sample.
  2. Set the following data: editor.setData( '<p><a href="test">te<strong>s</strong>t</a></p>' ).
  3. Put the caret at the beginning of the link.
  4. Keep pressing Arrow right until you reach the end of the link.

✅ Expected result

Two-step caret movement doesn't activate on inline elements inside the link.

❎ Actual result

Two-step caret movement activates on inline elements inside the link.

📃 Other details that might be useful

OS: All platforms
Browser: All browsers
@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Apr 6, 2018
@Reinmar Reinmar added this to the next milestone Apr 6, 2018
@oleq
Copy link
Member

oleq commented Apr 6, 2018

A piece of https://github.com/ckeditor/ckeditor5-engine/issues/1301.

@oleq
Copy link
Member

oleq commented Apr 10, 2018

This issue is no longer reproducible.

@oleq oleq closed this as completed Apr 10, 2018
@oleq oleq removed this from the next milestone Apr 10, 2018
@oleq oleq added this to the iteration 15 milestone Apr 10, 2018
@Reinmar
Copy link
Member

Reinmar commented Apr 10, 2018

Hm... we didn't change anything that could fix it I think. Are you sure it's not reproducible?

@Mgsy
Copy link
Member Author

Mgsy commented Apr 10, 2018

This issue is no longer reproducible.

@oleq, I'm afraid this bug is still reproducible.

bug_cke5

@oleq
Copy link
Member

oleq commented Apr 10, 2018

You're right. My bad.

@oleq oleq reopened this Apr 10, 2018
@oleq oleq modified the milestones: iteration 15, next Apr 10, 2018
@oleq oleq mentioned this issue Apr 16, 2018
Merged
scofalik added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 18, 2018
@scofalik
Merge pull request #1406 from ckeditor/t/1301
f0fd2d8 
Fix: The `bindTwoStepCaretToAttribute` behavioral helper should not fail in more complex cases. Closes #1301. Closes #1346. Closes ckeditor/ckeditor5#937.  Closes ckeditor/ckeditor5#922.  Closes ckeditor/ckeditor5#946.
@Reinmar Reinmar modified the milestones: next, iteration 16 Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 16
3 participants
@Reinmar @oleq @Mgsy