Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF] Exception after inserting whitespace while inline style is active #720

Closed
Mgsy opened this issue Dec 14, 2017 · 7 comments
Closed

[FF] Exception after inserting whitespace while inline style is active #720

Mgsy opened this issue Dec 14, 2017 · 7 comments
Labels
browser:firefox resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Dec 14, 2017

🐞 Is this a bug report or feature request? (choose one)

  • Bug report

💻 Version of CKEditor

1.0.0-alpha2

📋 Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Put the caret at the end of the Heading 1.
  3. Press Spacebar.
  4. Press Arrow left.
  5. Press Ctrl + B.
  6. Press Spacebar.

✅ Expected result

No error in the console.

❎ Actual result

There is the error in the console.

📃 Other details that might be useful

Error

TypeError: viewBlock is null mapper.js:86
   Mapper/< mapper.js:86
   fire emittermixin.js:269
   toModelPosition mapper.js:195
   _handleTextNodeInsertion input.js:298
   handle input.js:152
   _handleMutations input.js:105
   init/< input.js:50
   fire emittermixin.js:269
   _onMutations mutationobserver.js:248
   _onMutations self-hosted:954

GIF
bug_cke5

Notes
This bug occurs also if you put the selection at the beginning of the element. It's not reproducible when the selection is inside the caption.

Other information
OS: Windows 10, MacOS X

@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 14, 2017
@Mgsy Mgsy added this to the iteration 14 milestone Dec 14, 2017
@ma2ciek ma2ciek self-assigned this Dec 14, 2017
@ma2ciek
Copy link
Contributor

ma2ciek commented Dec 14, 2017

Something probably goes wrong with the Input plugin. The mutations change after InputCommand and the node's parent disappears. Also, it should be noted, that MutationObserver on the FF emits 2 view mutations, while on the Chrome emits only 1.

screen shot 2017-12-14 at 17 12 56

@Reinmar
Copy link
Member

Reinmar commented Jan 17, 2018

We had a talk about this issue back in December and we identified two problems there:

  1. That DomConverter._processDataFromDomText() loses the first space after <br> (or something similar – basically, it doesn't consider the <br> so it thinks that that space is a trailing space and trims it).
  2. That mutation observer doesn't correctly filter out <br> mutations in these cases.

Do I recall this correctly, @ma2ciek @szymonkups? PS. Always write down such notes right after a talk.

@ma2ciek
Copy link
Contributor

ma2ciek commented Jan 17, 2018

I remember, that we've been talking about the second, similar problem (#692) and our talks are concluded here: #692 (comment).

@ma2ciek
Copy link
Contributor

ma2ciek commented Feb 14, 2018

Notes for the 1. scenario:
Step 1. applies to paragraphs too.
At step 6, it can be any character.

  1. scenario for that error:
  2. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  3. Put the caret at: Para[]graph.
  4. Press Spacebar twice.
  5. Press Arrow left.
  6. Press Ctrl + B.
  7. Press any character.

It's different than #692. Here, all is about the bogus <br> tag IMO.

@Reinmar Reinmar modified the milestones: iteration 14, iteration 15 Mar 12, 2018
@Reinmar Reinmar modified the milestones: iteration 15, backlog, next Mar 30, 2018
@ma2ciek ma2ciek removed their assignment Oct 12, 2020
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox resolution:expired This issue was closed due to lack of feedback. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

6 participants