Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar items lack vertical spacing when wrapped to the next line #682

Closed
vladikoff opened this issue Nov 21, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#118
Closed

Toolbar items lack vertical spacing when wrapped to the next line #682

vladikoff opened this issue Nov 21, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#118
Assignees
@oleq
Labels
package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@vladikoff
Copy link

vladikoff commented Nov 21, 2017 •
edited
Loading

🐞 Is this a bug report or feature request?

  • Bug report (CSS/design)

💻 Version of CKEditor

dev.alpha-2

📋 Steps to reproduce

  1. Change the width of the editor to 240px on https://ckeditor5.github.io/
  2. Hover over the icon rows

✅ Expected result

Either a smaller dropdown height or more padding for the icons

❎ Actual result

the dropdown is super close to the icon focus / hover background

📃 Other details that might be useful

icons
@Reinmar Reinmar added package:theme-lark status:confirmed type:bug This issue reports a buggy (incorrect) behavior. labels Nov 21, 2017
@Reinmar
Copy link
Member

Reinmar commented Nov 21, 2017

We're in the middle of refactoring the theme to PostCSS, so let's better not touch this now. But I'm adding this to the milestone to not forget it.

@Reinmar Reinmar added this to the iteration 14 milestone Nov 21, 2017
@vladikoff
Copy link
Author

Awesome thanks! 🎨

@oleq oleq changed the title Icons focus / hover is too close to the heading dropdown Toolbar items lack vertical spacing when wrapped to the next line Nov 28, 2017
@oleq oleq mentioned this issue Dec 14, 2017
Merged
oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Dec 14, 2017
@oleq
Merge pull request #118 from ckeditor/t/ckeditor5-ui/333
ef4d421 
Feature: Implemented styles for the ButtonDropdown (see: ckeditor/ckeditor5-ui#333). Fixed spacing issues with toolbar items wrapped to the new line. Closes ckeditor/ckeditor5#682.

Also:
* Various improvements to visual styles of the dropdowns.
* Migrated toolbar to CSS `flex`.
* Allowed vertical toolbars.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

t/ckeditor5-ui/333: Implemented styles for the ButtonDropdown ckeditor/ckeditor5-theme-lark
3 participants
@vladikoff @Reinmar @oleq