Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link decorators don't handle a case where two decorators apply classes #6571

Closed
Reinmar opened this issue Apr 7, 2020 · 3 comments
Closed
Labels
package:link resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 7, 2020

📝 Provide detailed reproduction steps (if any)

This should work fine:

				isGallery: {
					mode: 'manual',
					label: 'Gallery link',
					attributes: {
						class: 'gallery'
					}
				},
				isWhatever: {
					mode: 'manual',
					label: 'Whatever link',
					attributes: {
						class: 'whatever'
					}
				}

But it does not.

getData() outputs the right thing:

<p>sdf <a class="gallery whatever" href="">sdf ds</a></p>

But setData() loses these attributes.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. package:link labels Apr 7, 2020
@Reinmar Reinmar added this to the backlog milestone Apr 7, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Apr 7, 2020

Most likely, the same thing is true also for styles.

From ckeditor/ckeditor5-link#258 on the same will be true for decorators which are truth by default (see https://github.com/ckeditor/ckeditor5-link/pull/258/files#r404808327).

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 12, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants