Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor misbehave when invoking bold with cursor placed inside bolded word #630

Closed
1 of 2 tasks
jodator opened this issue Oct 25, 2017 · 6 comments
Closed
1 of 2 tasks
Labels
resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Oct 25, 2017

🐞 Is this a bug report or feature request?

  • Bug report
  • Feature request

πŸ’» Version of CKEditor

alpha-1

πŸ“‹ Steps to reproduce

  1. Place cursor in some text (here I've found that on bolded us).
  2. Press ctrl+b several times.

βœ… Expected result

Cursor should stay in the same position.

❎ Actual result

Cursor 'dances'.

πŸ“ƒ Other details that might be useful

This cursor shift happens due to split of <strong>( <strong>u|s<strong> <=> <strong>u</strong>|<strong>s</strong>) in editing area.

screencast 2017-10-25 11_56_50

Similar thing happen with Browser's spellchecker which detects word split:
selection_011

@oleq
Copy link
Member

oleq commented Oct 25, 2017

I think I've seen a similar issue in the past but I couldn't find it. @pjasiun @scofalik?

@scofalik
Copy link
Contributor

The original issue is most probably a browser issue. When bold is turned off, editor data is <strong>u</strong>[]<strong>s</strong>. When it is on, the attributes are merged. This probably makes the caret to change its position.

The second issue (native spellchecker) is caused by the very same reason.

@jodator
Copy link
Contributor Author

jodator commented Oct 25, 2017

I've found this: #500:

Clicking on these links gives the impression that we're constantly breaking words in parts. In fact, the spell checking underline goes a bit crazy with it.

@oleq
Copy link
Member

oleq commented Oct 25, 2017

The second issue (native spellchecker) is caused by the very same reason.

Can we do anything about that? I'm not worried about wiggly caret because it's a minor annoyance. The native spell checker is the real issue hereβ€”it's a feature users really use and if it's broken, it could be a serious blocker.

@oleq
Copy link
Member

oleq commented Oct 25, 2017

I see that the issue is gone as soon as the selection changes. I guess the engine merges adjacent elements at that point and this is some generic mechanism. Could it also happen when the command was executed?
kapture 2017-10-25 at 13 10 26

@Reinmar
Copy link
Member

Reinmar commented Nov 15, 2017

The dancing caret is not a bug – I mean – not something worth our time.

The spellchecker is worse but it's something we can't solve with the current state of contentEditable. Actually, the problem with applying bold inside a middle of a word is not important, but the same happens with selections of other users.

I'm closing as "can't fix".

@Reinmar Reinmar closed this as completed Nov 15, 2017
@Reinmar Reinmar added resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior. labels Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants