Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve listenTo() and fire() function execution time #6195

Closed
mlewand opened this issue Feb 4, 2020 · 3 comments
Closed

Improve listenTo() and fire() function execution time #6195

mlewand opened this issue Feb 4, 2020 · 3 comments
Labels
package:font package:ui resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.

Comments

@mlewand
Copy link
Contributor

mlewand commented Feb 4, 2020

📝 Provide detailed reproduction steps (if any)

During the initialization of an editor with short content, listenTo and fire both combined account for ~9% self execution time of the entire initialization time (~110ms out of 1.23s).

Bottle-up list

We should try to improve this.

Here is a devtools profiler dump that can be viewed later on: editor-init-small.zip.

✔️ Expected result

Faster 🏃‍♀️

❌ Actual result

Slow 🐢

📃 Other details

This is a follow-up of #5880.

  • Browser: Chrome
  • OS: Windows (should be cross system)
  • CKEditor version: latest master

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added package:font package:ui type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement. labels Feb 4, 2020
@ma2ciek
Copy link
Contributor

ma2ciek commented Feb 4, 2020

Taking the occasion we could check if we can get rid of symbols in the EmitterMixin, this makes our CKEditor 5 utils impossible to use together with the bundled editor.

@mlewand mlewand mentioned this issue Feb 5, 2020
9 tasks
@Reinmar Reinmar added this to the backlog milestone Feb 18, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 10, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font package:ui resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Development

No branches or pull requests

5 participants