Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selection to be set on object elements #6154

Closed
jodator opened this issue Jan 28, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1820
Closed

Allow selection to be set on object elements #6154

jodator opened this issue Jan 28, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1820
Assignees
@jodator
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 29 (v17...

Comments

@jodator
Copy link
Contributor

jodator commented Jan 28, 2020

📝 Provide a description of the improvement

Right now, the selection post-fixer does not allow setting a selection inside limit elements. However, some deeply nested structure (tables) will require that a selection can be set inside the limit element on the object element. Such selection should not be fixed.

📃 Other details

This enables the #3202 in a way that post-fixer will not try to fix selection ranges that are set on object elements.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Jan 28, 2020
@jodator jodator mentioned this issue Jan 28, 2020
Merged
@jodator jodator added this to the iteration 29 milestone Jan 29, 2020
@jodator jodator self-assigned this Jan 29, 2020
@Reinmar Reinmar mentioned this issue Jan 31, 2020
Closed
21 tasks
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Feb 3, 2020
@Reinmar
Merge pull request #1820 from ckeditor/i/6154
0dec72d 
Other: Allow selection on object elements. Closes ckeditor/ckeditor5#6154.
jodator added a commit to ckeditor/ckeditor5-image that referenced this issue Feb 3, 2020
@jodator
Merge pull request #341 from ckeditor/i/6154
fd3d152 
Tests: Align test code to the latest changes in selection post-fixer. See ckeditor/ckeditor5#6154.
jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 3, 2020
@jodator
Merge pull request #229 from ckeditor/i/6154
ec22240 
Tests: Align test code to the latest changes in selection post-fixer. See ckeditor/ckeditor5#6154.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

I/6154: Allow selection on object element (ie. on table cells) ckeditor/ckeditor5-engine
1 participant
@jodator