Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon toolbar doesn't assume empty toolbar. #5980

Closed
jodator opened this issue Dec 16, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#534
Closed

Balloon toolbar doesn't assume empty toolbar. #5980

jodator opened this issue Dec 16, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#534
Assignees
@jodator
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@jodator
Copy link
Contributor

jodator commented Dec 16, 2019

📝 Provide detailed reproduction steps (if any)

  1. Use BalloonToolbar plugin
  2. Provide empty config
  3. no profit

✔️ Expected result

  • The editor should work

❌ Actual result

  • the editor blows up

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Dec 16, 2019
@jodator jodator added this to the iteration 29 milestone Dec 16, 2019
@jodator jodator self-assigned this Dec 16, 2019
@jodator jodator mentioned this issue Dec 16, 2019
Merged
Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Dec 20, 2019
@Reinmar
Merge pull request #534 from ckeditor/i/5980
1e05098 
Fix: Make `BlockToolbar` work with an empty configuration. Closes ckeditor/ckeditor5#5980.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

Make BlockToolbar work with empty configuration. ckeditor/ckeditor5-ui
2 participants
@jodator @Mgsy