Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BodyCollection UI component #5888

Closed
oskarwrobel opened this issue Dec 3, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#533
Closed

BodyCollection UI component #5888

oskarwrobel opened this issue Dec 3, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#533
Assignees
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@oskarwrobel
Copy link
Contributor

oskarwrobel commented Dec 3, 2019

EditorUIView provides a body collection for child views, detached from the DOM structure of the editor, like balloon panels, etc. Each plugin that introduces such a view uses this collection to display it.

Soon, we gonna have plugins that work out of the editor (Context plugins) and such plugins may need to display a balloon panel somehow. So, we gonna need something like an EditorUIView#body out of the editor.

Let's create a reusable BodyCollection component. EditorUIView will implement it as a body collection, for the editor plugins purpose (like it was before). Context plugin who's gonna needs a body collection will create its own.

@oskarwrobel oskarwrobel added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed labels Dec 3, 2019
@oskarwrobel oskarwrobel added this to the iteration 29 milestone Dec 3, 2019
@oskarwrobel oskarwrobel self-assigned this Dec 3, 2019
Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Jan 16, 2020
Feature: Reintroduced the concept of body collections with a focus on better management of multiple editors and support for context plugins (plugins which leave outside an editor instance). Closes ckeditor/ckeditor5#5888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant