Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enableEngineDebug functionality should be split between engine files #5649

Closed
ma2ciek opened this issue Oct 23, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1805
Closed

enableEngineDebug functionality should be split between engine files #5649

ma2ciek opened this issue Oct 23, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1805
Assignees
@ma2ciek
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 28 (v16...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Oct 23, 2019

Provide a description of the task

The current solution makes the usage of the enableEngineDebug problematically since the enableEngineDebug() function returns a plugin that needs to be added to the list of plugins in order to work. This makes the debugging experience harder because it forces every manual test to include that plugin in the plugin list to enable engine debugging.

An ideal situation would be if we could just run samples with the --debug engine flag set and no worry about each manual test. To achieve this we should split the functionality between our classes commented out with the // @if CK_DEBUG_ENGINE // phrase that our dev tools are able to uncomment.
@ma2ciek ma2ciek added the type:task This issue reports a chore (non-production change) and other types of "todos". label Oct 23, 2019
@ma2ciek ma2ciek added this to the iteration 28 milestone Oct 23, 2019
@ma2ciek ma2ciek self-assigned this Oct 23, 2019
@ma2ciek ma2ciek changed the title enableEngineDebug functionality should be split into engine files enableEngineDebug functionality should be split between engine files Oct 23, 2019
@ma2ciek
Copy link
Contributor Author

ma2ciek commented Oct 23, 2019

A potential follow-up: The provided informations that are displayed in the console could be displayed in our inspector as well if it's provided, but IDK if this would be a valuable improvement.

This was referenced Oct 23, 2019
Merged
Closed
pjasiun pushed a commit to ckeditor/ckeditor5-engine that referenced this issue Oct 25, 2019
Merge pull request #1805 from ckeditor/i/5649
353f091 
Other: Split debug tools between the engine files. You do not need to add debug plugin to the editor if you want to use `--debug engine` building flag anymore. Closes ckeditor/ckeditor5#5649.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 28 (v16.0.0)
Development

Successfully merging a pull request may close this issue.

Split debug tools between the engine files ckeditor/ckeditor5-engine
1 participant
@ma2ciek