-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection handler -> selection handle #4612
Labels
Milestone
Comments
We already used the correct "handle" noun in the image resize feature. |
oleq
referenced
this issue
in ckeditor/ckeditor5-table
Oct 8, 2019
…me "handle", see ckeditor/ckeditor5-widget#99).
oleq
referenced
this issue
in ckeditor/ckeditor5-theme-lark
Oct 8, 2019
…e ckeditor/ckeditor5-widget#99).
Reinmar
referenced
this issue
in ckeditor/ckeditor5-widget
Oct 9, 2019
Other: Renamed "handler" to "handle" in the entire package. Closes #99. BREAKING CHANGE: The `drag-handler.svg` icon is now `drag-handle.svg`. If you use it in your integration, please update the path. BREAKING CHANGE: The `hasSelectionHandler` option of the [`toWidget()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_widget_utils.html#static-function-toWidget) utility has been renamed to `hasSelectionHandle`. Consider this change if you create your own widgets using this helper. BREAKING CHANGE: `.ck-widget__selection-handler` and `.ck-widget_with-selection-handler` CSS classes set on widgets have been renamed to `.ck-widget__selection-handle` and `.ck-widget_with-selection-handle`. This change may affect styling in your integration.
Reinmar
referenced
this issue
in ckeditor/ckeditor5-table
Oct 9, 2019
Internal: Aligned to the rename in the ckeditor5-widget package ("handler" became "handle", see ckeditor/ckeditor5-widget#99).
Reinmar
referenced
this issue
in ckeditor/ckeditor5-theme-lark
Oct 9, 2019
Internal: Aligned widget class names to the refactoring in ckeditor5-widget (see ckeditor/ckeditor5-widget#99).
mlewand
added
status:confirmed
type:improvement
This issue reports a possible enhancement of an existing feature.
package:widget
labels
Oct 9, 2019
This was referenced Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Handler handles something. A handle is the thing that you grab.
The text was updated successfully, but these errors were encountered: