Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitbutton styles are broken after RTL integration #3425

Closed
oleq opened this issue Aug 12, 2019 · 0 comments
Closed

Splitbutton styles are broken after RTL integration #3425

oleq opened this issue Aug 12, 2019 · 0 comments
Assignees
@oleq

Comments

@oleq
Copy link
Member

oleq commented Aug 12, 2019

Regression after #1151.

Actual:

image

Expected:

image

All [dir="..."].ck-rounded-corners should be .ck-rounded-corners[dir="..."] in https://github.com/ckeditor/ckeditor5-theme-lark/blob/master/theme/ckeditor5-ui/components/dropdown/splitbutton.css#L17-L90
@oleq oleq self-assigned this Aug 12, 2019
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Aug 12, 2019
@oleq
Internal: Fixed broken split button styles after RTL integration. Clo…
26b42f7 
…ses #241.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oleq