Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table and column resizing (by mouse) #3284

Closed
Reinmar opened this issue Aug 27, 2019 · 13 comments
Closed

Table and column resizing (by mouse) #3284

Reinmar opened this issue Aug 27, 2019 · 13 comments
Labels
package:table resolution:resolved This issue was already resolved (e.g. by another ticket). squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 27, 2019

We've just introduced image resizing and we can quite easily implement a similar solution for tables too.

Then, the second thing is columns resizing. For this we cannot reuse the logic from image resizing so it's a far bigger task.

For the first implementation we'll focus on horizontal axis only (column resize, table width resize). If you're interested in row height resize head on to #11637 issue.

Note: It will be possible to resize rows/columns/tables by using the table styles feature.


If you'd like to see resizing in tables, please react with 👍 to this ticket and explain in the comment which part is crucial for you.

@ma2ciek
Copy link
Contributor

ma2ciek commented Aug 27, 2019

The ckeditor/ckeditor5-table#210 seems to partially solve this issue but I have not been analyzying it.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Oct 9, 2019
@farthinker
Copy link

The column width resize is very crucial for us. Table with table-layout: auto usually generates an unexpected result, and our user couldn't do anything about it.
But resizing the whole table is not necessary, as we always set the table width to 100%.

@Reinmar Reinmar changed the title Table and columns/rows resizing Table and columns/rows resizing (by mouse) Jan 30, 2020
@wwalc
Copy link
Member

wwalc commented May 22, 2020

A few questions, anyone interested in this feature please feel free to jump in.

  • What units should be used for resized columns (% or px)? If pixels then please explain why and what with ensuring that the content responsive?
  • Is it fine if only a column that the user decided to change will have the width set?

@vudzero
Copy link

vudzero commented Jun 17, 2020

I would mimic google docs or word resizing mechanism with the mouse, the end user does not care about % or px, they adjust the size with their mouse as they like and that's it. So I guess pixel under the hood.

@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Sep 21, 2020
@Reinmar Reinmar removed the squad:core Issue to be handled by the Core team. label Oct 21, 2020
@kuku711
Copy link

kuku711 commented May 10, 2021

A few questions, anyone interested in this feature please feel free to jump in.

  • What units should be used for resized columns (% or px)? If pixels then please explain why and what with ensuring that the content responsive?
  • Is it fine if only a column that the user decided to change will have the width set?

I will be happy to get this feature!

  • Units should be in % only, when all columns will have fix width and column will be added it will destroy the layout (will get more width then the document have).
  • While developing the feature you will see if set width is needed for all the table or just the touched columns.
    Thank you!!

@NeilD321
Copy link

Completely disagree with kuku711.
If a user resizes a table they are choosing to move from responsive to a set size and they are doing so for a reason. Table size when changed by the user using drag handles should be px. Otherwise the user does not know what will happen when viewed on other devices and that's the whole point. Our users are making documents, not responsive pages.

In the dialog though, let me choose.

Columns can be either.

@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Oct 27, 2021
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Nov 23, 2021
@rjschof
Copy link

rjschof commented Feb 18, 2022

@Reinmar Can we please get an update on where this feature might be on the roadmap?

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@neongreen
Copy link

Re/ px versus % — how do other editors do it? E.g. I think prosemirror/tiptap has mouse-resizable columns.

@neongreen
Copy link

Note: perhaps px vs % should be configurable when integrating the editor.

For some products, "our users are making documents, not responsive pages" is absolutely true. For our product (Brick), the opposite is true.

@mlewand mlewand added this to the iteration 53 milestone Apr 14, 2022
@mlewand mlewand added squad:features Issue to be handled by the Features team. and removed squad:core Issue to be handled by the Core team. labels Apr 14, 2022
@mlewand
Copy link
Contributor

mlewand commented Apr 14, 2022

We'll be starting with column resize (which will also allow to resize a table itself).

However, we won't tackle row resize yet, I've extracted it to a separate issue: #11637. For anyone interested in row resize, please upvote the linked issue too. This will allow us to better understand if there's a desire in community for this feature.

@mlewand mlewand changed the title Table and columns/rows resizing (by mouse) Table and column resizing (by mouse) Apr 14, 2022
@Reinmar Reinmar removed this from the iteration 53 milestone Apr 21, 2022
@Reinmar Reinmar added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 21, 2022
@neongreen
Copy link

Is this shipped already?

@richa0312
Copy link

richa0312 commented May 22, 2022

I want column resize feature so that all column should be uniform as per need, please do let us know when it will be ready with proper example.? @mlewand

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 31, 2022
@Reinmar
Copy link
Member Author

Reinmar commented Nov 1, 2022

This feature was shipped a couple months ago: https://ckeditor.com/docs/ckeditor5/latest/features/table.html#table-column-resize

@Reinmar Reinmar closed this as completed Nov 1, 2022
@Reinmar Reinmar added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table resolution:resolved This issue was already resolved (e.g. by another ticket). squad:features Issue to be handled by the Features team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests