Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement table styles (alignment) like image styles #3225

Open
jodator opened this issue Sep 4, 2018 · 6 comments
Open

Implement table styles (alignment) like image styles #3225

jodator opened this issue Sep 4, 2018 · 6 comments
Labels
package:table support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@jodator
Copy link
Contributor

jodator commented Sep 4, 2018

The table feature lacks defining table styles similar to the Image style plugin.

The alignment of table cells is a separate feature: #3218.

NOTE: Starting from 2020 Q2 it is possible to align tables by using the table styles panel. This option will work differently than predefined image styles mentioned in this ticket – table styles will be based on inline CSS styles, while image styles use predefined classes (more semantical approach). The semantic approach can still be applied to tables one day, though, so this ticket still makes sense.


If you'd like to see this feature implemented, add 👍 to this post.

@Reinmar Reinmar changed the title Implement Table styles (alignment) like Image styles. Implement Table styles (alignment) like Image styles Aug 27, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Oct 9, 2019
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Jan 7, 2020
@Reinmar
Copy link
Member

Reinmar commented Jan 20, 2020

Just to make it more visible:

NOTE: Starting from 2020 Q2 it will be possible to align tables by using the table styles panel.

See the note in the first post in this thread.

@Mgsy Mgsy modified the milestones: nice-to-have, iteration 29 Jan 21, 2020
@Reinmar Reinmar modified the milestones: iteration 29, nice-to-have Jan 23, 2020
@Reinmar
Copy link
Member

Reinmar commented Jan 23, 2020

@Mgsy, we're not going to work on this. The feature that we're working on in table styles is separate from this.

@Reinmar
Copy link
Member

Reinmar commented Sep 21, 2020

It'd be good to review the conflict that arose in the image feature between resize and image styles: https://ckeditor.com/docs/ckeditor5/latest/features/image.html#image-styles. The same conflict will cause our headache in the case of tables. If we want to change something in case of images, it'd be good to make that change before touching tables.

@Reinmar Reinmar removed the squad:core Issue to be handled by the Core team. label Oct 8, 2020
@Reinmar Reinmar changed the title Implement Table styles (alignment) like Image styles Implement table and media styles (alignment) like image styles Oct 8, 2020
@Reinmar Reinmar changed the title Implement table and media styles (alignment) like image styles Implement table styles (alignment) like image styles Oct 8, 2020
@Reinmar
Copy link
Member

Reinmar commented Oct 8, 2020

Media styles (alignment) is tracked in #2781.

@Reinmar
Copy link
Member

Reinmar commented Aug 2, 2021

DUP reported: #10289.

@bsmilling
Copy link

I completely agree that most of the table styles, like colors and widths, should be inline. But I think alignment should be based on classes, as you have multiple CSS properties (float, margin-left/-right) that need to be changed to get it to look good. Float alone doesn't cut it.

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

7 participants