Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial table selection must not be possible #3168

Closed
Reinmar opened this issue May 24, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1431 or ckeditor/ckeditor5-table#39
Closed
Assignees
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented May 24, 2018

Partial table selection must be fixed to a complete table selection.

Note that it's only partially related to the fact that we don't support cell/row/col selection yet. When the selection starts outside of a table, then even in the future we should rather extend the selection to the entire table if a part of it is selected (because mixing a real selection with a fake one will be hard). The behaviour will change only for cases when selection starts inside a table and spans a couple of cells. Right now, we have to prevent that somehow (either shrink the selection to a single cell or expand it to a whole table). In the future, this will trigger row/col selection mode.

may-24-2018 12-44-02

@jodator jodator self-assigned this Jun 5, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-engine Jun 18, 2018
Feature: Introduced a selection post-fixer. Its role is to ensure that after all changes are applied the selection is placed in a correct position. Closes #1156. Closes #1176. Closes #1182. Closes ckeditor/ckeditor5-table#11. Closes ckeditor/ckeditor5-table#12. Closes ckeditor/ckeditor5-table#15. Closes ckeditor/ckeditor5#562. Closes ckeditor/ckeditor5#611.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
3 participants